New issue
Advanced search Search tips

Issue 887983 link

Starred by 1 user
Status: Assigned
Owner:
asavery@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 655192



Sign in to add a comment

Add UMA stats for NVMe flash utilization

Project Member Reported by gwendal@chromium.org, Sep 21 
Add variable similar to eMMC variable Platform.Emmc.LifeUsed.Type[A|B], add a variable that track NVMe SMART reported statistic: "Percentage Used". The variable is available in /var/log/storage_info.txt.

It is present on Samsung and Kingston part, check it is available from other vendor as well.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bf8dd2e9cec19ea2db2d9b30856082e775a33fa9

commit bf8dd2e9cec19ea2db2d9b30856082e775a33fa9
Author: Alexis Savery <asavery@chromium.org>
Date: Fri Dec 21 03:04:19 2018

histograms: Add histograms for storage life used

Add UMA histogram "Platform.Storage.Nvme.PercentageUsed" for Chrome OS

    This tracks how the NVMe inside the device is aging.
    Part of NVMe specification, Percentage Used provides a vendor specific
    estimate of the percentage of NVM subsystem life used based on the
    actual usage and the prediction of NVM life.

Add UMA histogram "Platform.Storage.Ufs.LifeUsed[A|B]" for Chrome OS

    This tracks how the UFS inside the device is aging.
    Part of UFS specification, DeviceLifeTimeEst[A|B] provides an
    indication of the device life time based on the amount of performed
    program/erase cycles. The calculation methods are vendor specific
    and referred to as Method A|B.

Implementation CL:
https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1298433/

BUG=chromium:887983
TEST=ran validate_format.py

Change-Id: I4bf617cf735b23a7fcec9952661c4739537ac91f
Reviewed-on: https://chromium-review.googlesource.com/c/1297282
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Alexis Savery <asavery@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618441}
[modify] https://crrev.com/bf8dd2e9cec19ea2db2d9b30856082e775a33fa9/tools/metrics/histograms/histograms.xml
Project Member

Comment 2 by bugdroid, Today (3 hours ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/486cd6ac9909993b7e8ee83c0bd737ba4b572412

commit 486cd6ac9909993b7e8ee83c0bd737ba4b572412
Author: Alexis Savery <asavery@chromium.org>
Date: Wed Jan 23 05:05:21 2019

init: Report nvme and ufs device life used

Gather nvme percentage used and ufs life used information
from storage_info.txt and send it to UMA.

Add unit tests.

BUG=chromium:887983
TEST=Ran chromeos-disk-metrics-test.sh

Change-Id: I13a85c1d436e657841e3c03e7bc19b26a8eadf0d
Reviewed-on: https://chromium-review.googlesource.com/1298433
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Alexis Savery <asavery@chromium.org>
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>

[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/ufs_disk_metrics_4.golden
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/ufs_disk_metrics_1.golden
[modify] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/chromeos-disk-metrics
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/storage_info_5.txt
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/nvme_disk_metrics_2.golden
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/nvme_disk_metrics_1.golden
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/sata_disk_metrics_5.golden
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/nvme_disk_metrics_4.golden
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/sindin8de2_disk_metrics_5.golden
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/emmc_disk_metrics_4.golden
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/storage_info_4.txt
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/ufs_disk_metrics_5.golden
[modify] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/chromeos-disk-metrics-test.sh
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/ufs_disk_metrics_3.golden
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/ufs_disk_metrics_2.golden
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/nvme_disk_metrics_3.golden
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/sindin8de2_disk_metrics_4.golden
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/sata_disk_metrics_4.golden
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/emmc_disk_metrics_5.golden
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/nvme_disk_metrics_5.golden
Project Member

Comment 3 by bugdroid, Today (3 hours ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/486cd6ac9909993b7e8ee83c0bd737ba4b572412

commit 486cd6ac9909993b7e8ee83c0bd737ba4b572412
Author: Alexis Savery <asavery@chromium.org>
Date: Wed Jan 23 05:05:21 2019

init: Report nvme and ufs device life used

Gather nvme percentage used and ufs life used information
from storage_info.txt and send it to UMA.

Add unit tests.

BUG=chromium:887983
TEST=Ran chromeos-disk-metrics-test.sh

Change-Id: I13a85c1d436e657841e3c03e7bc19b26a8eadf0d
Reviewed-on: https://chromium-review.googlesource.com/1298433
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Alexis Savery <asavery@chromium.org>
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>

[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/ufs_disk_metrics_4.golden
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/ufs_disk_metrics_1.golden
[modify] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/chromeos-disk-metrics
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/storage_info_5.txt
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/nvme_disk_metrics_2.golden
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/nvme_disk_metrics_1.golden
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/sata_disk_metrics_5.golden
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/nvme_disk_metrics_4.golden
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/sindin8de2_disk_metrics_5.golden
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/emmc_disk_metrics_4.golden
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/storage_info_4.txt
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/ufs_disk_metrics_5.golden
[modify] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/chromeos-disk-metrics-test.sh
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/ufs_disk_metrics_3.golden
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/ufs_disk_metrics_2.golden
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/nvme_disk_metrics_3.golden
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/sindin8de2_disk_metrics_4.golden
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/sata_disk_metrics_4.golden
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/emmc_disk_metrics_5.golden
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/nvme_disk_metrics_5.golden
Project Member

Comment 4 by bugdroid, Today (3 hours ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/486cd6ac9909993b7e8ee83c0bd737ba4b572412

commit 486cd6ac9909993b7e8ee83c0bd737ba4b572412
Author: Alexis Savery <asavery@chromium.org>
Date: Wed Jan 23 05:05:21 2019

init: Report nvme and ufs device life used

Gather nvme percentage used and ufs life used information
from storage_info.txt and send it to UMA.

Add unit tests.

BUG=chromium:887983
TEST=Ran chromeos-disk-metrics-test.sh

Change-Id: I13a85c1d436e657841e3c03e7bc19b26a8eadf0d
Reviewed-on: https://chromium-review.googlesource.com/1298433
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Alexis Savery <asavery@chromium.org>
Reviewed-by: Gwendal Grignou <gwendal@chromium.org>

[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/ufs_disk_metrics_4.golden
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/ufs_disk_metrics_1.golden
[modify] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/chromeos-disk-metrics
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/storage_info_5.txt
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/nvme_disk_metrics_2.golden
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/nvme_disk_metrics_1.golden
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/sata_disk_metrics_5.golden
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/nvme_disk_metrics_4.golden
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/sindin8de2_disk_metrics_5.golden
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/emmc_disk_metrics_4.golden
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/storage_info_4.txt
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/ufs_disk_metrics_5.golden
[modify] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/chromeos-disk-metrics-test.sh
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/ufs_disk_metrics_3.golden
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/ufs_disk_metrics_2.golden
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/nvme_disk_metrics_3.golden
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/sindin8de2_disk_metrics_4.golden
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/sata_disk_metrics_4.golden
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/emmc_disk_metrics_5.golden
[add] https://crrev.com/486cd6ac9909993b7e8ee83c0bd737ba4b572412/init/tests/nvme_disk_metrics_5.golden
►

Sign in to add a comment