New issue
Advanced search Search tips

Issue 887964 link

Starred by 1 user
Status: Fixed
Owner:
cjgrant@chromium.org
Closed: Sep 27
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

<out dir>/monochrome_public_bundle install fails

Project Member Reported by tiborg@chromium.org, Sep 21 
Running <out dir>/monochrome_public_bundle install causes

File "out/Debug/bin/monochrome_public_bundle", line 28, in <module>
    sys.exit(main())
  File "out/Debug/bin/monochrome_public_bundle", line 25, in main
    target_cpu='arm')
  File "/usr/local/google/code/chromium3/src/build/android/apk_operations.py", line 1444, in RunForBundle
    bundle_generation_info=bundle_generation_info)
  File "/usr/local/google/code/chromium3/src/build/android/apk_operations.py", line 1381, in _RunInternal
    args.command.ProcessArgs(args)
  File "/usr/local/google/code/chromium3/src/build/android/apk_operations.py", line 960, in ProcessArgs
    abis=self.apk_helper.GetAbis())
AttributeError: 'NoneType' object has no attribute 'GetAbis'

Comment 1 by cjgrant@chromium.org, Sep 25

Owner: cjgrant@chromium.org
Status: Started (was: Available)
Just tripped on this for the ChromeModern bundle.  I'll take this.

Logcat is also broken (and may have been before).

Comment 2 by cjgrant@chromium.org, Sep 27 

To properly fix this, I think we want devil's apk_helper.py to natively grok bundles.  I filed internal b/116794667 to ask if this can be supported.

For now, we can eliminate the crash by simply disabling the ABI-specific device query in the bundle case.  In other words, if we're loading a bundle, don't try to pull a list of supported ABIs from the bundle, because we can't - instead, just go back to specifying which device you want to load.
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/135f2e132bb84ac5d78f2c782dbcd4d9e3beba97

commit 135f2e132bb84ac5d78f2c782dbcd4d9e3beba97
Author: Christopher Grant <cjgrant@chromium.org>
Date: Thu Sep 27 21:18:41 2018

Fix bundle installing and debugging in APK helper scripts

A recent improvement to the APK wrapper scripts queries the target APK
for its native ABI, so it can ignore devices that don't match.
Unfortunately this broke bundle installation, since we can't yet run the
same ABI query on a bundle.

BUG= 887964 

Change-Id: I52c18a39ebb5b2714731826e2797e1fc18ab0a0e
Reviewed-on: https://chromium-review.googlesource.com/1249901
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594862}
[modify] https://crrev.com/135f2e132bb84ac5d78f2c782dbcd4d9e3beba97/build/android/apk_operations.py

Comment 4 by cjgrant@chromium.org, Sep 27

Status: Fixed (was: Started)
►

Sign in to add a comment