tast-tests repo needs pre-upload hook to check for "informational" attribute on new tests |
|||
Issue descriptionWe should have a pre-upload hook in the tast-tests repository that verifies that any new test files (i.e. new files matched by src/chromiumos/tast/*/bundles/*/*/*.go) contain "informational" in their Attr list during registration. I'm not sure of the best way to check for this. Maybe just making sure that new files contain "informational" (in double-quotes) is good enough for now. Making tests "important" by default was a deliberate choice (see http://doc/1ZyozTa907IJqw7QJNHaWIQ07v0szpUOzdLG2K6cURII), but it means it's easy for people to accidentally check in flaky tests that run on the CQ. It's also possible that it was the wrong choice...
,
Sep 25
,
Sep 26
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/tast-tests/+/3ddbf09bde8ebe6a0ad7e302309f721b68d1c5e2 commit 3ddbf09bde8ebe6a0ad7e302309f721b68d1c5e2 Author: Shuhei Takahashi <nya@chromium.org> Date: Wed Sep 26 17:33:21 2018 Add a pre-upload script to ensure new tests are marked informational. BUG= chromium:887940 TEST=scripts/check_informational_unittest.py TEST=scripts/check_informational.py 82a43e913c33dc2e; echo $? Change-Id: I5a250a338d9b75efba2d0aba49876d51ef21fe72 Reviewed-on: https://chromium-review.googlesource.com/1242824 Commit-Ready: Shuhei Takahashi <nya@chromium.org> Tested-by: Shuhei Takahashi <nya@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> [add] https://crrev.com/3ddbf09bde8ebe6a0ad7e302309f721b68d1c5e2/scripts/check_informational.py [add] https://crrev.com/3ddbf09bde8ebe6a0ad7e302309f721b68d1c5e2/scripts/check_informational_unittest.py [add] https://crrev.com/3ddbf09bde8ebe6a0ad7e302309f721b68d1c5e2/PRESUBMIT.cfg
,
Sep 27
|
|||
►
Sign in to add a comment |
|||
Comment 1 by nya@chromium.org
, Sep 25