New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 887937 link

Starred by 1 user
Status: Fixed
Owner:
brat...@opera.com
Closed: Nov 20
Cc:
█ e...@chromium.org
dpranke@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Re-add the gn emacs mode code to the chromium repo

Project Member Reported by brat...@opera.com, Sep 21 
The gn mode for Emacs was, and is, defined inside the gn repo so when the gn code moved elsewhere it took the gn mode code with it. I'm going to re-add a copy of it to the Chromium source tree so that it will be available when needed.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ad5d0999de853622dc7a6d94b77e1204c0cbb183

commit ad5d0999de853622dc7a6d94b77e1204c0cbb183
Author: Daniel Bratell <bratell@opera.com>
Date: Fri Sep 21 16:35:18 2018

Bring back gn.el for the Emacs GN mode

gn.el used to be in the chromium source tree until gn moved
elsewhere. Now it lives somewhere else,
https://gn.googlesource.com/gn/+/master/tools/gn/misc/emacs/gn-mode.el
which makes it less useful.

This is a copy of that file as of today. The file is not updated
often, and when it is, it's just to add more keywords so
nothing critical.

Bug:  887937 
Change-Id: I39335815a2cc8ecfe2b0e1728443f6abe84a85fa
Reviewed-on: https://chromium-review.googlesource.com/1238462
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#593217}
[modify] https://crrev.com/ad5d0999de853622dc7a6d94b77e1204c0cbb183/docs/emacs.md
[add] https://crrev.com/ad5d0999de853622dc7a6d94b77e1204c0cbb183/tools/emacs/gn.el

Comment 2 by brat...@opera.com, Nov 20

Status: Fixed (was: Assigned)
-> Fixed since it happened
►

Sign in to add a comment