New issue
Advanced search Search tips

Issue 887936 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: ‘Saved Password’ text along with entered password is not seen totally upon entering long password.

Reported by aiman.an...@etouch.net, Sep 21

Issue description

Chrome Version: 71.0.3558.0 (Official Build) Revision 09438e58ad92274e6fa5f7a76429836ceeba5fa5-refs/branch-heads/3558@{#1} (64-bit)

OS: Windows(7,8,8.1,10), Mac(10,12,6, 10.13.1, 10.13.5), Linux(14.04 LTS).

Pre-Condition: 1. Enable 'Automatic Password Generation' Flag from chrome://flags and relaunch the browser.
               2. Sign in to Chrome browser.

What steps will reproduce the problem?
1. Launch chrome, navigate to www.facebook.com Sign-Up page
2. In password field click once and select Auto-Generated password.
3. Add more characters in the password field(as shown in the video).
4. Mouse-Hover again on Password Generation field and observe the suggestion dropdown.

Actual: ‘Saved Password’ text along with entered password is not seen totally upon entering long password.
Expected: ‘Saved Password’ text should be seen along with entered password.

This is a regression issue, broken in M-70 series, and below is the per-revision-bisect-info

Good Build:69.0.3497.0(Revision:576754)
Bad Build:70.0.3498.0(Revision:577006)

You are probably looking for a change made after 576879 (known good), but no later than 576880 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/c212d589584d15b2835210e9344614626b1f0156..68b785b9db4853ca2762d1f356256849bd405c44

Suspect: https://chromium.googlesource.com/chromium/src/+/68b785b9db4853ca2762d1f356256849bd405c44

ericwilligers@ Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Kindly refer the screencast from the link given below
https://drive.google.com/drive/folders/1wDPnZFWLjNom1Fu0Uwki2Vig9sxGAZaO?usp=sharing

Thank You!


 













 
Owner: vasi...@chromium.org
I am not familiar with password UI.

vasilii@chromium.org can you please investigate.

My change seems unlikely to be relevant, facebook does not use quirks mode.

Cc: maxwalker@chromium.org
The dropdown has a max width of 480dp. Thus, I think the behavior is expected. Right, Max?
Thanks for catching this. Yes, the "Saved password" text label should always be visible. The edited password should be truncated on the right if it doesn't fit in the max-width dropdown. Updated specs to cover this edge case (https://gallery.googleplex.com/projects/MCHbtQVoQ2HCZRT3KyGvNYc6/files/MCEGxH4Xyp10GcTPe49gBVxzwMSJbxAVNpw, Google internal link).
Specs.png
72.9 KB View Download
Screenshot from 2018-10-08 10-54-44.png
16.5 KB View Download
Project Member

Comment 5 by bugdroid1@chromium.org, Oct 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e1fd5aaf5977ad5f1bd6a41cb3310e371c16fd7a

commit e1fd5aaf5977ad5f1bd6a41cb3310e371c16fd7a
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Mon Oct 08 09:53:57 2018

Don't truncate "Saved password" in the generation dropdown.

Bug:  887936 
Change-Id: I0d26f044019b6a73f4fcec7f5b6a88d707cc7c15
Reviewed-on: https://chromium-review.googlesource.com/c/1268115
Reviewed-by: Dominic Battré <battre@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597512}
[modify] https://crrev.com/e1fd5aaf5977ad5f1bd6a41cb3310e371c16fd7a/chrome/browser/ui/views/passwords/password_generation_popup_view_views.cc

Status: Fixed (was: Assigned)
Labels: TE-Verified-M71 TE-Verified-71.0.3574.0
Hi,

Retested the bug on Windows(7,8,8.1,10), Mac(10,12,6, 10.13.1, 10.13.6, 10.14), Linux(14.04 LTS) OS using latest Canary build #71.0.3574.0 and issue is fixed.

Now, Save password text is seen when entered password is long.

Kindly refer the attached screen-cast.

Thank You!
Canary Behaviour.mov
10.3 MB View Download

Sign in to add a comment