Issue metadata
Sign in to add a comment
|
Enter Passphrase popup text should be in Uppercase letters. |
||||||||||||||||||||||
Issue descriptionApp Version: 70.0.3538.28 beta iOS Version: iOS 10.3.3,11.4 Device: iPhone,iPad Precondition: 1- Sign into chrome which has passphrase account Username : ipuntoevo2@gmail.com Pswd : @lt123456 Steps to reproduce: 1. Launch Chrome 2. Open NTP Observed results: Enter Passphrase text is in lowercase letters Expected results: Enter Passphrase text should be in Upper case letters. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: NA Bug reproducible on Dolphin/Safari/Firefox: Safari : NA Bug reproducible on the current beta channel build : No in M69 Bug reproducible on the current beta channel build : Yes in M70 Link to video/image: IMAGE : https://drive.google.com/file/d/1Dg5k36TBNN4EptTTKTIQ4983SS2NZfel/view?usp=sharing
,
Sep 24
+pschaffner - I believe that the change from [ENTER PASSPHRASE] as button label to [Enter Passphrase] as button label is by design.
,
Sep 27
Correct, this is by design. We are consciously deviating from many MD typography standards (including casing) in favor of system conventions. One thing I noticed from the linked screenshot, however, is that the label was not using title casing, as it was [Enter passphrase]. This is incorrect and should be as pkl@ wrote it in #2: [Enter Passphrase]. Assigning to pkl@ to make sure title casing is used.
,
Sep 27
Ah, Pete, thank you for spotting that. It is probably the intent of the original bug report. One can interpret "Enter Passphrase text should be in Upper case letters" to mean "Enter Passphrase text should be in Title Casing" instead of "Enter Passphrase text should be in ALL CAPS". I took it to mean the latter, but OP may be thinking of the former. The change should be in ios/chrome/app/strings/ios_strings.grd by changing IDS_IOS_SYNC_ENTER_PASSPHRASE to "Enter Passphrase". I'll get to that.
,
Sep 28
,
Sep 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fb75324b04b0bbfdeeb602a350cbb7a3769be43f commit fb75324b04b0bbfdeeb602a350cbb7a3769be43f Author: Peter K. Lee <pkl@chromium.org> Date: Sat Sep 29 19:19:13 2018 Button labels should use Title Case It was erroneously set to "Enter passphrase" but never discovered because Material uses ALL CAPS which hides the incorrect use of lowercase on the second word. Bug: 887932 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: Ia3ff5efefb992ca326ac3f94be3be13d78e1f831 Reviewed-on: https://chromium-review.googlesource.com/1252535 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#595325} [modify] https://crrev.com/fb75324b04b0bbfdeeb602a350cbb7a3769be43f/ios/chrome/app/strings/ios_strings.grd
,
Oct 5
,
Nov 13
Verified in: App Version: 71.0.3578.49 beta Devices: iPhone 6 Plus, iPhone 6S Plus iOS Version: 11.4.1, 12.1.1 beta 2 'Enter Passphrase' text is using Title casing. Please refer to screenshot attached. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by stkhapugin@chromium.org
, Sep 21Owner: pkl@chromium.org
Status: Assigned (was: Untriaged)