Implicit dependency on too new version of libatspi-2 |
|||
Issue descriptionAdding support for Aura Linux to ax_dump_events added an implicit dependency on a too new version of libatspi-2. We should fix this issue and allow Chromium to compile against older versions again.
,
Sep 21
,
Oct 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e05e900cb8fc887d2f9284ea7184457177e88f55 commit e05e900cb8fc887d2f9284ea7184457177e88f55 Author: Martin Robinson <mrobinson@igalia.com> Date: Thu Oct 11 18:37:03 2018 Allow compilation against older atspi-2 versions Since atspi-2 does not support getting version information at compile time, we must do this manually with pkg-config. Add defines for the versions of atspi-2 that we care about and guard newer enum values with those defines. Bug: 887908 Change-Id: I8eecb2eeada48cc2176117b764adbf77b26ce351 Reviewed-on: https://chromium-review.googlesource.com/c/1238437 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#598863} [modify] https://crrev.com/e05e900cb8fc887d2f9284ea7184457177e88f55/build/config/linux/BUILD.gn [modify] https://crrev.com/e05e900cb8fc887d2f9284ea7184457177e88f55/build/config/linux/pkg-config.py [modify] https://crrev.com/e05e900cb8fc887d2f9284ea7184457177e88f55/content/browser/accessibility/accessibility_tree_formatter_utils_auralinux.cc
,
Oct 12
Works now! Thanks! |
|||
►
Sign in to add a comment |
|||
Comment 1 by mrobin...@igalia.com
, Sep 21