No way to access PictureInPictureWindow when initiated by the user agent. |
||||||||
Issue descriptionAs raised in https://github.com/WICG/picture-in-picture/issues/79, we should provide a way to access Picture-in-Picture window when user-agent initiates Picture-in-Picture. We'll add a pictureInPictureWindow to the enterpictureinpicture event.
,
Sep 25
,
Oct 3
,
Oct 3
This bug requires manual review: We are only 12 days from stable. Please contact the milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 3
This is a P3, does it really need to be in M70?
,
Oct 3
This wasn't meant to be a P3. The API has changed and we would like to make sure we have the API properly updated for the launch.
,
Oct 4
How safe is this merge? Has this been tested at all?
,
Oct 4
Approving merge - this is behind finch flag.
,
Oct 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/39c503c4e4df655bacc9b30eedff14cca32e2b1c commit 39c503c4e4df655bacc9b30eedff14cca32e2b1c Author: François Beaufort <beaufort.francois@gmail.com> Date: Fri Oct 05 08:24:08 2018 Add pictureInPictureWindow to enterpictureinpicture event. This makes sure web developers can access to the PictureInPicture window object when user agent initiates Picture-in-Picture. It does so by adding a pictureInPictureWindow attribute to the existing enterpictureinpicture event Intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/ibVPbqBQapU/Fgf307XJBgAJ Change-Id: I46ce1f4047b670f49dd746e39c7e62efc1b4a135 Bug: 887856 Reviewed-on: https://chromium-review.googlesource.com/1228122 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#593127}(cherry picked from commit c1e0949e0eebb9bf1c03234b777d8289c73b2b48) Reviewed-on: https://chromium-review.googlesource.com/c/1264200 Reviewed-by: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/branch-heads/3538@{#871} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} [modify] https://crrev.com/39c503c4e4df655bacc9b30eedff14cca32e2b1c/third_party/WebKit/LayoutTests/external/wpt/picture-in-picture/enter-picture-in-picture.html [modify] https://crrev.com/39c503c4e4df655bacc9b30eedff14cca32e2b1c/third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/39c503c4e4df655bacc9b30eedff14cca32e2b1c/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/39c503c4e4df655bacc9b30eedff14cca32e2b1c/third_party/blink/renderer/bindings/modules/BUILD.gn [modify] https://crrev.com/39c503c4e4df655bacc9b30eedff14cca32e2b1c/third_party/blink/renderer/modules/modules_idl_files.gni [modify] https://crrev.com/39c503c4e4df655bacc9b30eedff14cca32e2b1c/third_party/blink/renderer/modules/picture_in_picture/BUILD.gn [modify] https://crrev.com/39c503c4e4df655bacc9b30eedff14cca32e2b1c/third_party/blink/renderer/modules/picture_in_picture/DEPS [add] https://crrev.com/39c503c4e4df655bacc9b30eedff14cca32e2b1c/third_party/blink/renderer/modules/picture_in_picture/enter_picture_in_picture_event.cc [add] https://crrev.com/39c503c4e4df655bacc9b30eedff14cca32e2b1c/third_party/blink/renderer/modules/picture_in_picture/enter_picture_in_picture_event.h [add] https://crrev.com/39c503c4e4df655bacc9b30eedff14cca32e2b1c/third_party/blink/renderer/modules/picture_in_picture/enter_picture_in_picture_event.idl [add] https://crrev.com/39c503c4e4df655bacc9b30eedff14cca32e2b1c/third_party/blink/renderer/modules/picture_in_picture/enter_picture_in_picture_event_init.idl [modify] https://crrev.com/39c503c4e4df655bacc9b30eedff14cca32e2b1c/third_party/blink/renderer/modules/picture_in_picture/picture_in_picture_controller_impl.cc
,
Oct 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/39c503c4e4df655bacc9b30eedff14cca32e2b1c Commit: 39c503c4e4df655bacc9b30eedff14cca32e2b1c Author: beaufort.francois@gmail.com Commiter: beaufort.francois@gmail.com Date: 2018-10-05 08:24:08 +0000 UTC Add pictureInPictureWindow to enterpictureinpicture event. This makes sure web developers can access to the PictureInPicture window object when user agent initiates Picture-in-Picture. It does so by adding a pictureInPictureWindow attribute to the existing enterpictureinpicture event Intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/ibVPbqBQapU/Fgf307XJBgAJ Change-Id: I46ce1f4047b670f49dd746e39c7e62efc1b4a135 Bug: 887856 Reviewed-on: https://chromium-review.googlesource.com/1228122 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#593127}(cherry picked from commit c1e0949e0eebb9bf1c03234b777d8289c73b2b48) Reviewed-on: https://chromium-review.googlesource.com/c/1264200 Reviewed-by: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/branch-heads/3538@{#871} Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811} |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Sep 21