New issue
Advanced search Search tips

Issue 887844 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Sep 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:[Print Preview]Textbox appears chopped from bottom and blue focus highlight is not visible

Reported by vineetha...@etouch.net, Sep 21

Issue description

Chrome Version: 71.0.3558.0 (Official Build) Revision 09438e58ad92274e6fa5f7a76429836ceeba5fa5-refs/branch-heads/3558@{#1}(32/64-bit)
OS:Windows (7, 8, 8.1 ,10)

Pre-condition: Sign in to chrome with valid credentials

What steps will reproduce the problem?
1. Launch chrome, give print command (Ctrl + P) to open Print Preview overlay.
2. Click on 'Change' button under 'Destination' and select 'Save to Google Drive' option from 'Print Destinations'.
3. Now click on 'More Settings' > 'Change Printer options...' button under 'Advanced' to open 'Advanced settings for ...'.
4. Observe textbox. 

Actual Result  : Textbox appears chopped from bottom and blue focus highlight is not visible.
Expected Result: Textbox should not appear chopped and blue focus highlight should be visible.

This is a regression issue broken in ‘M-71’ and will soon update bisect information:
Good Build : 71.0.3557.0 (Revision : 592638)
Bad Build  : 71.0.3558.2 (Revision : 593042)

 
ActualVideo.mp4
479 KB View Download
ExpectedVideo.mp4
513 KB View Download
Owner: rbpotter@chromium.org
Labels: hasbisect-per-revision OS-Linux OS-Mac
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 592983 (known good), but no later than 592984 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/c625b2d97a6a8d52c400fdff08f024d3c3d71575..512dbfe98d30ce05cf7f3554444562ee90d44493

Suspect : https://chromium.googlesource.com/chromium/src/+/512dbfe98d30ce05cf7f3554444562ee90d44493

From the CL above, assigning the issue to the concern owner 

@rbpotter- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: Issue is also seen on Mac(10.12.6, 10.13.1, 10.13.6, 10.14) and Linux(14.04 LTS)

Thanks!
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9d55e69819faffc4c086e81b3dec8530839239c

commit a9d55e69819faffc4c086e81b3dec8530839239c
Author: rbpotter <rbpotter@chromium.org>
Date: Mon Sep 24 22:18:35 2018

Print Preview Refresh: Fix cut off cr-input in advanced dialog

Also fix a bug where enter still leads to print if one of the
paper-buttons on the page is focused (should open dialog instead).
Previously print preview did not have paper-buttons, so  did not check
this case.

Bug:  887844 ,  888465 
Change-Id: Ie041ace8ea0fd5d62096331efba727af55e935f5
Reviewed-on: https://chromium-review.googlesource.com/1239365
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593713}
[modify] https://crrev.com/a9d55e69819faffc4c086e81b3dec8530839239c/chrome/browser/resources/print_preview/new/advanced_settings_item.html
[modify] https://crrev.com/a9d55e69819faffc4c086e81b3dec8530839239c/chrome/browser/resources/print_preview/new/app.js

Labels: TE-Verified-M71 TE-Verified-71.0.3561.0
Update :
Rechecked the above issue on Win(7,8,8.1,10) ,Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14) and Linux(14.04 LTS)OS with Canary version #71.0.3561.0 and the issue is fixed.

Kindly refer the attached screen cast.
CanaryBehaviour.mp4
491 KB View Download
Status: Verified (was: Assigned)

Sign in to add a comment