Regression: Text 'Collate' on print preview is seen chopped on changing font size.
Reported by
pranjali...@etouch.net,
Sep 21
|
|||||
Issue descriptionChrome Version: 71.0.3558.0 (Official Build) 09438e58ad92274e6fa5f7a76429836ceeba5fa5-refs/branch-heads/3558@{#1}(32/64-bit) OS: Windows(7,8,8.1,10) What steps will reproduce the problem? 1. Launch chrome and navigate to 'chrome://settings/appearance'. 2.Change font size to 'Large' and give print command. 3.Now enter number of copies such that collate option appears and observe. Actual Result: Text 'Collate' on print preview is seen chopped on changing font size. Expected Result: Text 'Collate' on print preview is seen chopped on changing font size. This is regression issue broken in ‘M-71’ and and soon update other bisect info Good build: 71.0.3557.0 Bad build : 71.0.3558.0
,
Sep 21
Using the 'per-revision' script providing the bisect result: You are probably looking for a change made after 592978 (known good), but no later than 592979 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/17143592261946d391de629230e47eef90787a1b..569651fe903bf5b1a9e6ebf721541c2a54fb5a28 Suspect : https://chromium.googlesource.com/chromium/src/+/569651fe903bf5b1a9e6ebf721541c2a54fb5a28 From the CL above, assigning the issue to the concern owner @rbpotter- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thanks!
,
Sep 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e659696b565b65c4b89a2d117c8b4dba5cf30f9 commit 5e659696b565b65c4b89a2d117c8b4dba5cf30f9 Author: rbpotter <rbpotter@chromium.org> Date: Sat Sep 22 01:13:17 2018 Print Preview Refresh: Fix some spacing issues (1) For cr-input: Do not apply cr row container mixin to inner div. This was done accidentally while adding the prefix slot. (2) Adjust heights/margins so that collate checkbox ripple is not cut off and collate does not cause the copies section to shift when it appears. (3) Ensure collate breaks the word if it is too large, to fix possible issues with large font sizes/languages where "collate" translates to something with a very long word. (4) Reduce checkbox padding - this helps with collate and aligns with UX request to reduce checkbox padding to as little as possible, without cutting off the ripple. (5) Add margin-top: 16 for settings sections, which allows extra padding applied to more-settings when expanded to be removed (fixes animation issue). Bug: 887837 , 887839 , 887704 Change-Id: I9d3a9bc468ce0ee5b4a2ecfb136233d3a1054902 Reviewed-on: https://chromium-review.googlesource.com/1239333 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#593403} [modify] https://crrev.com/5e659696b565b65c4b89a2d117c8b4dba5cf30f9/chrome/browser/resources/print_preview/new/copies_settings.html [modify] https://crrev.com/5e659696b565b65c4b89a2d117c8b4dba5cf30f9/chrome/browser/resources/print_preview/new/more_settings.html [modify] https://crrev.com/5e659696b565b65c4b89a2d117c8b4dba5cf30f9/chrome/browser/resources/print_preview/new/more_settings.js [modify] https://crrev.com/5e659696b565b65c4b89a2d117c8b4dba5cf30f9/chrome/browser/resources/print_preview/new/number_settings_section.html [modify] https://crrev.com/5e659696b565b65c4b89a2d117c8b4dba5cf30f9/chrome/browser/resources/print_preview/new/other_options_settings.html [modify] https://crrev.com/5e659696b565b65c4b89a2d117c8b4dba5cf30f9/chrome/browser/resources/print_preview/new/print_preview_shared_css.html [modify] https://crrev.com/5e659696b565b65c4b89a2d117c8b4dba5cf30f9/chrome/browser/resources/print_preview/new/settings_section.html [modify] https://crrev.com/5e659696b565b65c4b89a2d117c8b4dba5cf30f9/ui/webui/resources/cr_elements/cr_input/cr_input.html
,
Sep 25
Update: Verified the fix on Windows(7,8,8.1,10) ,Mac(10.12.6 , 10.13.1 , 10.13.6 , 10.14) and Linux(14.04 LTS) as per comment#0 using latest canary build#71.0.3561.0 and fix is working as intended. Hence Adding the verified labels. Attaching screen cast for reference
,
Sep 25
,
Sep 25
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by thestig@chromium.org
, Sep 21