New issue
Advanced search Search tips

Issue 887827 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Remove IncrementalShadowDOM flag and code clean up

Project Member Reported by hayato@chromium.org, Sep 21

Issue description

IncrementalShadowDOM is launched at M69.

We can remove IncremetalShadowDOM flag.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f3fcfebe20ce1496552a0c20880d3b8140680b53

commit f3fcfebe20ce1496552a0c20880d3b8140680b53
Author: Hayato Ito <hayato@chromium.org>
Date: Tue Sep 25 11:47:08 2018

Remove IncrementalShadowDOM flag

M69 stable got IncrementalShadowDOM. Now we can remove the flag.

Further code clean-up will be done in follow-up CLs.

Bug:  887827 
Change-Id: I197259be347015ebc28cc518e31251e86dd3df90
Reviewed-on: https://chromium-review.googlesource.com/1237775
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593893}
[modify] https://crrev.com/f3fcfebe20ce1496552a0c20880d3b8140680b53/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/f3fcfebe20ce1496552a0c20880d3b8140680b53/third_party/blink/renderer/core/dom/flat_tree_traversal_test.cc
[modify] https://crrev.com/f3fcfebe20ce1496552a0c20880d3b8140680b53/third_party/blink/renderer/core/dom/node.cc
[modify] https://crrev.com/f3fcfebe20ce1496552a0c20880d3b8140680b53/third_party/blink/renderer/core/dom/shadow_root.cc
[modify] https://crrev.com/f3fcfebe20ce1496552a0c20880d3b8140680b53/third_party/blink/renderer/core/dom/shadow_root.h
[modify] https://crrev.com/f3fcfebe20ce1496552a0c20880d3b8140680b53/third_party/blink/renderer/core/dom/shadow_root_v0.cc
[modify] https://crrev.com/f3fcfebe20ce1496552a0c20880d3b8140680b53/third_party/blink/renderer/core/dom/slot_assignment.cc
[modify] https://crrev.com/f3fcfebe20ce1496552a0c20880d3b8140680b53/third_party/blink/renderer/core/dom/slot_assignment.h
[modify] https://crrev.com/f3fcfebe20ce1496552a0c20880d3b8140680b53/third_party/blink/renderer/core/dom/slot_assignment_test.cc
[modify] https://crrev.com/f3fcfebe20ce1496552a0c20880d3b8140680b53/third_party/blink/renderer/core/dom/v0_insertion_point.cc
[modify] https://crrev.com/f3fcfebe20ce1496552a0c20880d3b8140680b53/third_party/blink/renderer/core/html/html_slot_element.cc
[modify] https://crrev.com/f3fcfebe20ce1496552a0c20880d3b8140680b53/third_party/blink/renderer/core/html/html_slot_element.h
[modify] https://crrev.com/f3fcfebe20ce1496552a0c20880d3b8140680b53/third_party/blink/renderer/core/inspector/inspector_dom_agent.cc
[modify] https://crrev.com/f3fcfebe20ce1496552a0c20880d3b8140680b53/third_party/blink/renderer/platform/runtime_enabled_features.json5

Project Member

Comment 2 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7fb4c7b38dab398f9c526e025e5e27186f55c802

commit 7fb4c7b38dab398f9c526e025e5e27186f55c802
Author: Hayato Ito <hayato@chromium.org>
Date: Wed Sep 26 07:55:05 2018

Remove dead code

A follow up CL after https://crrev.com/c/1237775.

Bug:  887827 
Change-Id: Ic055e3609b7f59f800b0121ff8ba65295b1eaf11
Reviewed-on: https://chromium-review.googlesource.com/1245060
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594244}
[modify] https://crrev.com/7fb4c7b38dab398f9c526e025e5e27186f55c802/third_party/blink/renderer/core/dom/slot_assignment.h

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9bcd9948617c0fcccaea75af0ac6077ad56d2e36

commit 9bcd9948617c0fcccaea75af0ac6077ad56d2e36
Author: Hayato Ito <hayato@chromium.org>
Date: Wed Sep 26 08:25:40 2018

Remove outdated comment

A follow up CL after https://crrev.com/c/1237775.

Bug:  887827 
Change-Id: Ie4fb2fbfef5d3a112949195a9ee1ae1d2c067674
Reviewed-on: https://chromium-review.googlesource.com/1243879
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594250}
[modify] https://crrev.com/9bcd9948617c0fcccaea75af0ac6077ad56d2e36/third_party/blink/renderer/core/dom/slot_assignment.h

Project Member

Comment 4 by bugdroid1@chromium.org, Sep 27

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8017b9e61c361bd2222127b61d7af2657714b6dc

commit 8017b9e61c361bd2222127b61d7af2657714b6dc
Author: Hayato Ito <hayato@chromium.org>
Date: Thu Sep 27 04:38:15 2018

Update or remove outdated comments

Some comments are outdated after Incremental Shadow DOM is enabled.

Bug:  887827 
Change-Id: Icfb10ca01aed8418fce2d7a16b9e03501aa724d7
Reviewed-on: https://chromium-review.googlesource.com/1245342
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594593}
[modify] https://crrev.com/8017b9e61c361bd2222127b61d7af2657714b6dc/third_party/blink/renderer/core/dom/document.cc
[modify] https://crrev.com/8017b9e61c361bd2222127b61d7af2657714b6dc/third_party/blink/renderer/core/dom/node.h

Summary: Remove IncrementalShadowDOM flag and code clean up (was: Remove IncrementalShadowDOM flag)
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/75d661af023d81699d4d4e8a06e8d5a47ca829ea

commit 75d661af023d81699d4d4e8a06e8d5a47ca829ea
Author: Hayato Ito <hayato@chromium.org>
Date: Fri Sep 28 03:51:35 2018

Remove abstraction which is no longer necessary

Use AssignedNodes() directly. The abstraction here is no longer
necessary since we removed IncrementalShadowDOM flag.

Bug:  887827 
Change-Id: Id5c7e4139ad89ce2ade6efd62bdfc1cbb50c0340
Reviewed-on: https://chromium-review.googlesource.com/1249467
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594976}
[modify] https://crrev.com/75d661af023d81699d4d4e8a06e8d5a47ca829ea/third_party/blink/renderer/core/html/html_slot_element.cc
[modify] https://crrev.com/75d661af023d81699d4d4e8a06e8d5a47ca829ea/third_party/blink/renderer/core/html/html_slot_element.h

Project Member

Comment 7 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/293371c1a3ffa61d3d8d77cc5057e0bc41d95db5

commit 293371c1a3ffa61d3d8d77cc5057e0bc41d95db5
Author: Hayato Ito <hayato@chromium.org>
Date: Fri Sep 28 05:03:15 2018

Remove HTMLSlotElement's dead member fields

There members are no longer necessary after Incremental Shadow DOM is shipped.

Bug:  887827 
Change-Id: Ic1e389f248de401f367d031f5ae13242e1fe6dca
Reviewed-on: https://chromium-review.googlesource.com/1249474
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594985}
[modify] https://crrev.com/293371c1a3ffa61d3d8d77cc5057e0bc41d95db5/third_party/blink/renderer/core/html/html_slot_element.cc
[modify] https://crrev.com/293371c1a3ffa61d3d8d77cc5057e0bc41d95db5/third_party/blink/renderer/core/html/html_slot_element.h

Status: Fixed (was: Assigned)

Sign in to add a comment