New issue
Advanced search Search tips

Issue 887825 link

Starred by 1 user
Status: Fixed
Owner:
thestig@chromium.org
Closed: Sep 22
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Normal PDF printing and raster printing are not consistent

Project Member Reported by thestig@chromium.org, Sep 21 
Chrome Version: 69.0.3497.81
OS: Linux (and ChromeOS)

What steps will reproduce the problem?
(1) Open https://www.irs.gov/pub/irs-pdf/fw4.pdf in 2 windows side-by-side.
(2) Print Preview in both windows.
(3) Select the same printer in both windows.
(4) Click "More settings" -> "Print as image" in one of the windows.

What is the expected result?

Both print preview documents look exactly the same.

What happens instead?

The "Print as image" copy has forms that appear blue/purple. Which is not intended for printing.

We can improve this by unifying the PDF conversion code. The two code paths should look the same, except the "Print as image" path should do an extra rasterization step. Currently, the two code paths are rather different.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5cc4dd615a4d6ab0993a4c674761866934a5ed2

commit c5cc4dd615a4d6ab0993a4c674761866934a5ed2
Author: Lei Zhang <thestig@chromium.org>
Date: Sat Sep 22 06:07:46 2018

Add PDFiumPrint::CreatePrintPdf() method.

Split most of the code in PDFiumPrint::PrintPagesAsPdf() into a separate
method. CreatePrintPdf() will be reused in an upcoming CL.

BUG= 887825 

Change-Id: I0e6fee3a6908cee038a45e5a7f62182559f33df4
Reviewed-on: https://chromium-review.googlesource.com/1238076
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593433}
[modify] https://crrev.com/c5cc4dd615a4d6ab0993a4c674761866934a5ed2/pdf/pdfium/pdfium_print.cc
[modify] https://crrev.com/c5cc4dd615a4d6ab0993a4c674761866934a5ed2/pdf/pdfium/pdfium_print.h
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d985bd37ce4f2fd5aba28c0ec264d97ddab20356

commit d985bd37ce4f2fd5aba28c0ec264d97ddab20356
Author: Lei Zhang <thestig@chromium.org>
Date: Sat Sep 22 06:13:32 2018

Merge PDF printing paths.

Make PDFiumPrint::PrintPagesAsRasterPdf() and PrintPagesAsPdf()
consistent. Now they both call CreatePrintPdf() to generate a PDF for
printing. The only difference is PrintPagesAsPdf() does an extra
rasterization step.

BUG= 887825 

Change-Id: I1f02f6acfa5833d33bf999933fa681c10b67ccf9
Reviewed-on: https://chromium-review.googlesource.com/1238077
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593434}
[modify] https://crrev.com/d985bd37ce4f2fd5aba28c0ec264d97ddab20356/pdf/pdfium/pdfium_page.cc
[modify] https://crrev.com/d985bd37ce4f2fd5aba28c0ec264d97ddab20356/pdf/pdfium/pdfium_page.h
[modify] https://crrev.com/d985bd37ce4f2fd5aba28c0ec264d97ddab20356/pdf/pdfium/pdfium_print.cc
[modify] https://crrev.com/d985bd37ce4f2fd5aba28c0ec264d97ddab20356/pdf/pdfium/pdfium_print.h

Comment 3 by thestig@chromium.org, Sep 22

Status: Fixed (was: Assigned)
►

Sign in to add a comment