Regression : [Print Preview]Unnecessary hand pointer is seen on disabled 'Print using system dialog...' link button.
Reported by
rp...@etouch.net,
Sep 21
|
||
Issue descriptionChrome Version: 71.0.3557.0 (Official Build)Revision 409ad95fbafba7ca90dc799c9a0be24d3abb549f-refs/branch-heads/3557@{#1}(32/64-bit) OS: Windows(7,8,8.1,10),Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14) and Linux(14.04 LTS) What steps will reproduce the problem? 1. Launch chrome, navigate to NTP and press 'Ctrl + p' to open print preview 2. Type any invalid text in 'Pages' text field so that all fields appear in disable state and then hover mouse over 'Print using system dialog...' link button,observe Actual Result: Unnecessary hand pointer is seen when mouse is hovered on disabled 'Print using system dialog...' link button. Expected Result: Hand pointer should not be seen when mouse is hovered on disabled 'Print using system dialog...' link button. This is regression issue broken in ‘M-71’ and will soon update other info: Good build: 71.0.3556.0(Revision: 592302) Bad build : 71.0.3557.0(Revision: 592637) You are probably looking for a change made after 592613 (known good), but no later than 592614 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/282b263f46a04b847af8ca36e359cb5c18574225..740492f9aba228edd794d7bd9d148d0929895a54 Suspect : https://chromium.googlesource.com/chromium/src/+/740492f9aba228edd794d7bd9d148d0929895a54 From the CL above, assigning the issue to the concern owner @rbpotter- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thanks!
,
Sep 24
Update : Rechecked the above issue on Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1,10.13.6,10.14) using latest Canary build : 71.0.3559.0 and the issue is still reproducible. Kindly refer the attached screen cast. Thank you..!!
,
Sep 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4970413d8808b5a5ecc191127bdc9e736d2f8229 commit 4970413d8808b5a5ecc191127bdc9e736d2f8229 Author: rbpotter <rbpotter@chromium.org> Date: Tue Sep 25 18:20:34 2018 Print Preview Refresh: Fix some pages and link container polish bugs - Make cr-input full height of radio button so there is no border area where the hand pointer appears. - Ignore pointer events on link container when disabled. - Fix bug where "----" was considered valid input in pages. Bug: 884603 , 887823 , 888493 Change-Id: Ie9b7f2c42b12d7e2a7026f405b1a61b774578589 Reviewed-on: https://chromium-review.googlesource.com/1242037 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#594013} [modify] https://crrev.com/4970413d8808b5a5ecc191127bdc9e736d2f8229/chrome/browser/resources/print_preview/new/link_container.html [modify] https://crrev.com/4970413d8808b5a5ecc191127bdc9e736d2f8229/chrome/browser/resources/print_preview/new/pages_settings.html [modify] https://crrev.com/4970413d8808b5a5ecc191127bdc9e736d2f8229/chrome/browser/resources/print_preview/new/pages_settings.js [modify] https://crrev.com/4970413d8808b5a5ecc191127bdc9e736d2f8229/chrome/test/data/webui/print_preview/pages_settings_test.js
,
Sep 26
Tested and this seems to be fixed in 71.0.3562.1 Canary (Win 10). |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Sep 21