New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 887800 link

Starred by 1 user
Status: Fixed
Owner:
█ yoshiki@chromium.org
Last visit > 30 days ago
Closed: Sep 21
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Chrome OS Toast remains after removing it just after unlocking screen

Project Member Reported by yoshiki@chromium.org, Sep 21 
Chrome OS ToT

What steps will reproduce the problem?
(1) Show a toast on lock screen
(2) Unlock the screen
(3) Remove the toast immediately after unlocking

What is the expected result?
Toast should get hidden

What happens instead?
Toast doesn't get hidden, keeps visible

Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 21 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5a00728256156294aeedd775dc300282f1ad096

commit a5a00728256156294aeedd775dc300282f1ad096
Author: yoshiki iguchi <yoshiki@chromium.org>
Date: Fri Sep 21 02:46:21 2018

Hide a toast correctly just after unlocking

There was the bug that a toast didn't get hidden if it was removed
just after unlocking the screen. This bug had been introduced by
http://crrev.com/b7c2ea2a2ca1fa8b7eb8aece0bee0a965735dcda.

Toast changes the window container which it belongs to referring
the current device lock status: locked or unlocked, because chrome
os has different window containers for locked and unlocked desktop.

That commit had changed the timing of changing the window container and
that had caused the bug. We had the code not to hide a toast on animation,
but that change had added an animation on the changing.

This CL removes the code, since it is no longer necessary because the
change timing was changed.

Bug:  887800 
Test: manual

Change-Id: I2942227af9bc9eebb8c5881920341f25d68e91d5
Reviewed-on: https://chromium-review.googlesource.com/1235513
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593059}
[modify] https://crrev.com/a5a00728256156294aeedd775dc300282f1ad096/ash/system/toast/toast_overlay.cc

Comment 2 by yoshiki@chromium.org, Sep 21

Status: Fixed (was: Started)
►

Sign in to add a comment