New issue
Advanced search Search tips

Issue 887799 link

Starred by 1 user

Issue metadata

Status: Assigned
Merged: issue 340934
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Cannot pick a file from <input type="file"> on data: URL

Project Member Reported by hirono@chromium.org, Sep 21

Issue description

Chrome Version: 71.0.3554.0
OS: Chrome

What steps will reproduce the problem?
(1) Type data:text/html,<input type="file"> in the omnibox
(2) Click the file input
(3) Select a file under Google Drive

What is the expected result?
File in Google Drive can be picked

What happens instead?
File in Google Drive can not be picked
 
Cc: tkent@chromium.org
weifangsun@ - Could you triage the issue? It seems selecting Drive file by <input> tag is regressed. Reported by tkent@

Cc: weifangsun@chromium.org
Labels: M-71
Owner: ----
hirono@ - Thanks for raising. Can you confirm - which "omnibox" are you referring to? (Chrome, Launcher search, Files app search?)
Mergedinto: 340934
Status: Duplicate (was: Available)
Looks like a dupe - please re-open if you think it's not the same.
Status: Available (was: Duplicate)
No.  Issue 340934  is specific to 'webkitdirectory' attribute.  This isn't.

Owner: lucmult@chromium.org
Status: Assigned (was: Available)
Luciano - can you check that this is not caused by the new UI work?
I can confirm that I can reproduce this issue. Can you clarify one thing, using <input> in the omnibox is a use-case (if so can you explain more?), or is just an easy way to reproduce the issue?

The DCHECK that I get by running it in my workstation:
[125489:125489:1016/110852.583178:FATAL:gurl.cc(166)] Check failed: false. Trying to get the spec of an invalid URL!
#0 0x7f22efaf052f base::debug::StackTrace::StackTrace()
#1 0x7f22efa2397b logging::LogMessage::~LogMessage()
#2 0x7f22efce7df8 GURL::spec()
#3 0x7f22eaa39bf0 storage::FileSystemURL::ToGURL()
#4 0x55959c949e69 file_manager::util::ConvertSelectedFileInfoListToFileChooserFileInfoList()
#5 0x55959e97423d FileSelectHelper::NotifyRenderFrameHostAndEnd()
#6 0x55959e973e97 FileSelectHelper::FileSelectedWithExtraInfo()
#7 0x7f22e9b471a0 views::Widget::OnNativeWidgetDestroying()
#8 0x7f22e9b64170 views::NativeWidgetAura::OnWindowDestroying()
#9 0x7f22eaf57aa3 aura::Window::~Window()
#10 0x7f22eaf584ae aura::Window::~Window()
#11 0x7f22e9b30357 _ZN4base8internal7InvokerINS0_9BindStateIMN5views12MouseWatcher8ObserverEFvvEJNS_7WeakPtrIS5_EEEEEFvvEE7RunOnceEPNS0_13BindStateBaseE
#12 0x7f22efa06cda base::debug::TaskAnnotator::RunTask()
#13 0x7f22efa31f6f base::MessageLoop::RunTask()
#14 0x7f22efa32363 base::MessageLoop::DoWork()
#15 0x7f22efb13a19 base::MessagePumpLibevent::Run()
#16 0x7f22efa31b14 base::MessageLoop::Run()
#17 0x7f22efa64479 base::RunLoop::Run()
#18 0x55959cf095ed ChromeBrowserMainParts::MainMessageLoopRun()
#19 0x7f22eca1fae7 content::BrowserMainLoop::RunMainMessageLoopParts()
#20 0x7f22eca225e6 content::BrowserMainRunnerImpl::Run()
#21 0x7f22eca1c0c9 content::BrowserMain()
#22 0x7f22ed4c6a7e content::ContentMainRunnerImpl::Run()
#23 0x7f22efdb20d5 service_manager::Main()
#24 0x7f22ed4c4dc4 content::ContentMain()
#25 0x55959c10a0d3 ChromeMain
#26 0x7f22e06492b1 __libc_start_main
#27 0x55959c109f4a _start

Received signal 6
#0 0x7f22efaf052f base::debug::StackTrace::StackTrace()
#1 0x7f22efaf0031 base::debug::(anonymous namespace)::StackDumpSignalHandler()
#2 0x7f22e1f260c0 <unknown>
#3 0x7f22e065bfcf gsignal
#4 0x7f22e065d3fa abort
#5 0x7f22efaeeea5 base::debug::BreakDebugger()
#6 0x7f22efa23d46 logging::LogMessage::~LogMessage()
#7 0x7f22efce7df8 GURL::spec()
#8 0x7f22eaa39bf0 storage::FileSystemURL::ToGURL()
#9 0x55959c949e69 file_manager::util::ConvertSelectedFileInfoListToFileChooserFileInfoList()
#10 0x55959e97423d FileSelectHelper::NotifyRenderFrameHostAndEnd()
#11 0x55959e973e97 FileSelectHelper::FileSelectedWithExtraInfo()
#12 0x7f22e9b471a0 views::Widget::OnNativeWidgetDestroying()
#13 0x7f22e9b64170 views::NativeWidgetAura::OnWindowDestroying()
#14 0x7f22eaf57aa3 aura::Window::~Window()
#15 0x7f22eaf584ae aura::Window::~Window()
#16 0x7f22e9b30357 _ZN4base8internal7InvokerINS0_9BindStateIMN5views12MouseWatcher8ObserverEFvvEJNS_7WeakPtrIS5_EEEEEFvvEE7RunOnceEPNS0_13BindStateBaseE
#17 0x7f22efa06cda base::debug::TaskAnnotator::RunTask()
#18 0x7f22efa31f6f base::MessageLoop::RunTask()
#19 0x7f22efa32363 base::MessageLoop::DoWork()
#20 0x7f22efb13a19 base::MessagePumpLibevent::Run()
#21 0x7f22efa31b14 base::MessageLoop::Run()
#22 0x7f22efa64479 base::RunLoop::Run()
#23 0x55959cf095ed ChromeBrowserMainParts::MainMessageLoopRun()
#24 0x7f22eca1fae7 content::BrowserMainLoop::RunMainMessageLoopParts()
#25 0x7f22eca225e6 content::BrowserMainRunnerImpl::Run()
#26 0x7f22eca1c0c9 content::BrowserMain()
#27 0x7f22ed4c6a7e content::ContentMainRunnerImpl::Run()
#28 0x7f22efdb20d5 service_manager::Main()
#29 0x7f22ed4c4dc4 content::ContentMain()
#30 0x55959c10a0d3 ChromeMain
#31 0x7f22e06492b1 __libc_start_main
#32 0x55959c109f4a _start
  r8: 0000000000000000  r9: 00007ffead0db7d0 r10: 0000000000000008 r11: 0000000000000246
 r12: 00007ffead0dc2a0 r13: 00007ffead0dc290 r14: 00007ffead0dc298 r15: 00007ffead0dc241
  di: 0000000000000002  si: 00007ffead0db7d0  bp: 00007ffead0dba10  bx: 0000000000000006
  dx: 0000000000000000  ax: 0000000000000000  cx: 00007f22e065bfcf  sp: 00007ffead0db848
  ip: 00007f22e065bfcf efl: 0000000000000246 cgf: 002b000000000033 erf: 0000000000000000
 trp: 0000000000000000 msk: 0000000000000000 cr2: 0000000000000000
[end of stack trace]
Calling _exit(1). Core file will not be generated.


I'm checking further.


It's just an easy way to reproduce the issue. Thank you for taking a look at the issue!
It seems to be related to "origin".

I tried the same thing with a page served from localhost:8000 and it succeeds, I added several logs and traced to these 2 differences between localhost:8000 and data:url ...

This brings back to what is the use case of data:text/html.

From data: url :
[167708:167708:1016/123839.931209:ERROR:fileapi_util.cc(294)] virtual_path: drive-lucmulttestcros%40gmail.com-hash/root/image-drive.png origin: data:text/html,<input type="file"> c
ontext: /tmp/a8/u-lucmulttestcros@gmail.com-hash
[167708:167708:1016/123839.931258:ERROR:fileapi_util.cc(633)] original_url:  type: 106 filesystem_id: drive-lucmulttestcros%40gmail.com-hash mount_type: 3 path: /special/drive-lucm
ulttestcros%40gmail.com-hash/root/image-drive.png
[167708:167708:1016/123839.931332:ERROR:gurl.cc(82)] input_spec: filesystem:isolated/ invalid
[167708:167708:1016/123839.931313:ERROR:fileapi_util.cc(650)] isolated_url: filesystem:5BACD6B2947E758275CCDFF37F4FA5D2/image-drive.png (Drive@drive-lucmulttestcros%40gmail.com-has
h:/special/drive-lucmulttestcros%40gmail.com-hash/root/image-drive.png)
[167708:167708:1016/123839.931370:ERROR:gurl.cc(82)] input_spec: filesystem:isolated/ invalid

From localhost:8000 :

[167708:167708:1016/123757.514581:ERROR:fileapi_util.cc(294)] virtual_path: drive-lucmulttestcros%40gmail.com-hash/root/image-drive.png origin: http://localhost/ context: /tmp/a8/u-lucmulttestcros@gmail.com-hash
[167708:167708:1016/123757.514617:ERROR:fileapi_util.cc(633)] original_url:  type: 106 filesystem_id: drive-lucmulttestcros%40gmail.com-hash mount_type: 3 path: /special/drive-lucmulttestcros%40gmail.com-hash/root/image-drive.png
[167708:167708:1016/123757.514690:ERROR:gurl.cc(82)] input_spec: filesystem:http://localhost/isolated/ valid
[167708:167708:1016/123757.514669:ERROR:fileapi_util.cc(650)] isolated_url: filesystem:http://localhost/isolated/6F2AD3AD1E221467B98C43BF4AEB192E/image-drive.png (Drive@drive-lucmulttestcros%40gmail.com-hash:/special/drive-lucmulttestcros%40gmail.com-hash/root/image-drive.png)
[167708:167708:1016/123757.514723:ERROR:gurl.cc(82)] input_spec: filesystem:http://localhost/isolated/ valid
[167708:167708:1016/123757.514745:ERROR:gurl.cc(82)] input_spec: filesystem:http://localhost/isolated/6F2AD3AD1E221467B98C43BF4AEB192E/image-drive.png valid



Labels: -Pri-1 -M-71 Pri-3
Oh, I confirmed file upload worked on pages other than data: URLs.  This issue specific to data: URLs.  So this is very minor issue, and should not have high-priority.

Summary: Cannot pick a file from <input type="file"> on data: URL (was: Cannot pick a file from <input type="file">)

Sign in to add a comment