New issue
Advanced search Search tips

Issue 887780 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Move TrayBubbleView from //ui/views/bubble into //ash

Project Member Reported by jamescook@chromium.org, Sep 21

Issue description

It's only used in //ash and has aura dependencies.

 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76e9205457111b813ecd8bc36d6c12153b21bd14

commit 76e9205457111b813ecd8bc36d6c12153b21bd14
Author: James Cook <jamescook@chromium.org>
Date: Fri Sep 21 23:10:30 2018

chromeos: Move TrayBubbleView from views to ash

It's only used in ash code. It also has aura dependencies, which is
unexpected for general-purpose views code (which supports non-aura
Views on Mac).

This makes it easier to find when we audit code in ash for mustash.

Bug:  887780 
Test: ash_unittests
Change-Id: I0380d94f695ac747475f3e7527059d7f8e597041
Reviewed-on: https://chromium-review.googlesource.com/1238545
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593365}
[modify] https://crrev.com/76e9205457111b813ecd8bc36d6c12153b21bd14/ash/BUILD.gn
[modify] https://crrev.com/76e9205457111b813ecd8bc36d6c12153b21bd14/ash/message_center/message_center_bubble.cc
[modify] https://crrev.com/76e9205457111b813ecd8bc36d6c12153b21bd14/ash/message_center/message_center_bubble.h
[modify] https://crrev.com/76e9205457111b813ecd8bc36d6c12153b21bd14/ash/system/accessibility/dictation_button_tray.cc
[modify] https://crrev.com/76e9205457111b813ecd8bc36d6c12153b21bd14/ash/system/accessibility/dictation_button_tray.h
[modify] https://crrev.com/76e9205457111b813ecd8bc36d6c12153b21bd14/ash/system/accessibility/select_to_speak_tray.h
[modify] https://crrev.com/76e9205457111b813ecd8bc36d6c12153b21bd14/ash/system/ime_menu/ime_menu_tray.cc
[modify] https://crrev.com/76e9205457111b813ecd8bc36d6c12153b21bd14/ash/system/ime_menu/ime_menu_tray.h
[modify] https://crrev.com/76e9205457111b813ecd8bc36d6c12153b21bd14/ash/system/media_security/multi_profile_media_tray_item_unittest.cc
[modify] https://crrev.com/76e9205457111b813ecd8bc36d6c12153b21bd14/ash/system/message_center/notification_tray.cc
[modify] https://crrev.com/76e9205457111b813ecd8bc36d6c12153b21bd14/ash/system/message_center/notification_tray.h
[modify] https://crrev.com/76e9205457111b813ecd8bc36d6c12153b21bd14/ash/system/overview/overview_button_tray.cc
[modify] https://crrev.com/76e9205457111b813ecd8bc36d6c12153b21bd14/ash/system/overview/overview_button_tray.h
[modify] https://crrev.com/76e9205457111b813ecd8bc36d6c12153b21bd14/ash/system/palette/palette_tray.cc
[modify] https://crrev.com/76e9205457111b813ecd8bc36d6c12153b21bd14/ash/system/palette/palette_tray.h
[modify] https://crrev.com/76e9205457111b813ecd8bc36d6c12153b21bd14/ash/system/status_area_widget.cc
[modify] https://crrev.com/76e9205457111b813ecd8bc36d6c12153b21bd14/ash/system/tray/system_tray.cc
[modify] https://crrev.com/76e9205457111b813ecd8bc36d6c12153b21bd14/ash/system/tray/system_tray.h
[modify] https://crrev.com/76e9205457111b813ecd8bc36d6c12153b21bd14/ash/system/tray/system_tray_bubble.cc
[modify] https://crrev.com/76e9205457111b813ecd8bc36d6c12153b21bd14/ash/system/tray/system_tray_bubble.h
[modify] https://crrev.com/76e9205457111b813ecd8bc36d6c12153b21bd14/ash/system/tray/tray_background_view.cc
[modify] https://crrev.com/76e9205457111b813ecd8bc36d6c12153b21bd14/ash/system/tray/tray_background_view.h
[modify] https://crrev.com/76e9205457111b813ecd8bc36d6c12153b21bd14/ash/system/tray/tray_bubble_base.h
[rename] https://crrev.com/76e9205457111b813ecd8bc36d6c12153b21bd14/ash/system/tray/tray_bubble_view.cc
[rename] https://crrev.com/76e9205457111b813ecd8bc36d6c12153b21bd14/ash/system/tray/tray_bubble_view.h
[modify] https://crrev.com/76e9205457111b813ecd8bc36d6c12153b21bd14/ash/system/tray/tray_bubble_wrapper.cc
[modify] https://crrev.com/76e9205457111b813ecd8bc36d6c12153b21bd14/ash/system/tray/tray_bubble_wrapper.h
[modify] https://crrev.com/76e9205457111b813ecd8bc36d6c12153b21bd14/ash/system/unified/unified_slider_bubble_controller.cc
[modify] https://crrev.com/76e9205457111b813ecd8bc36d6c12153b21bd14/ash/system/unified/unified_slider_bubble_controller.h
[modify] https://crrev.com/76e9205457111b813ecd8bc36d6c12153b21bd14/ash/system/unified/unified_system_tray.cc
[modify] https://crrev.com/76e9205457111b813ecd8bc36d6c12153b21bd14/ash/system/unified/unified_system_tray.h
[modify] https://crrev.com/76e9205457111b813ecd8bc36d6c12153b21bd14/ash/system/unified/unified_system_tray_bubble.cc
[modify] https://crrev.com/76e9205457111b813ecd8bc36d6c12153b21bd14/ash/system/unified/unified_system_tray_bubble.h
[modify] https://crrev.com/76e9205457111b813ecd8bc36d6c12153b21bd14/ash/system/virtual_keyboard/virtual_keyboard_tray.cc
[modify] https://crrev.com/76e9205457111b813ecd8bc36d6c12153b21bd14/ash/system/virtual_keyboard/virtual_keyboard_tray.h
[modify] https://crrev.com/76e9205457111b813ecd8bc36d6c12153b21bd14/ui/views/BUILD.gn
[modify] https://crrev.com/76e9205457111b813ecd8bc36d6c12153b21bd14/ui/views/bubble/OWNERS

Status: Fixed (was: Started)

Sign in to add a comment