New issue
Advanced search Search tips

Issue 887745 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 25
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: PasswordManagerInteractiveTest.AutofillPasswordFormWithoutUsernameField



Sign in to add a comment

PasswordManagerInteractiveTest.AutofillPasswordFormWithoutUsernameField is flaky

Project Member Reported by Findit, Sep 20

Issue description


Flaky test: PasswordManagerInteractiveTest.AutofillPasswordFormWithoutUsernameField
Sample failed build due to flakiness: https://chromium-swarm.appspot.com/task?id=40119689039e9710
Test output log: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-rel/13620
Culprit (100.0% confidence): https://chromium-review.googlesource.com/q/Ib748de088912221c3af18435286904046befb58f
Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy2QELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKiAWNocm9taXVtLmNocm9taXVtb3MvbGludXgtY2hyb21lb3MtcmVsLzEzNjIwL2ludGVyYWN0aXZlX3VpX3Rlc3RzL1VHRnpjM2R2Y21STllXNWhaMlZ5U1c1MFpYSmhZM1JwZG1WVVpYTjBMa0YxZEc5bWFXeHNVR0Z6YzNkdmNtUkdiM0p0VjJsMGFHOTFkRlZ6WlhKdVlXMWxSbWxsYkdRPQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM

Please revert the culprit, or disable the test and find the appropriate owner.

If the culprit above is wrong, please file a bug using this link:
https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20PasswordManagerInteractiveTest.AutofillPasswordFormWithoutUsernameField&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy2QELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKiAWNocm9taXVtLmNocm9taXVtb3MvbGludXgtY2hyb21lb3MtcmVsLzEzNjIwL2ludGVyYWN0aXZlX3VpX3Rlc3RzL1VHRnpjM2R2Y21STllXNWhaMlZ5U1c1MFpYSmhZM1JwZG1WVVpYTjBMa0YxZEc5bWFXeHNVR0Z6YzNkdmNtUkdiM0p0VjJsMGFHOTFkRlZ6WlhKdVlXMWxSbWxsYkdRPQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM
 
Cc: anthonyvd@chromium.org
Owner: ftirelo@chromium.org
Status: Assigned (was: Untriaged)
+Fabio, it looks like your CL at https://chromium-review.googlesource.com/c/chromium/src/+/1210165 was identified as the culprit. Can you please take a look at this flake? Thanks!
Cc: ftirelo@chromium.org
Owner: blundell@chromium.org
Status: Started (was: Assigned)
Reverting in https://chromium-review.googlesource.com/c/chromium/src/+/1242944; we'll see if it applies cleanly.
The revert did not apply cleanly.

On closer examination, it looks like that CL was just renaming the test in question, so the flake was pre-existing (and in fact, the tests around that one were already disabled for flakiness). Will disable the test in question.
Project Member

Comment 5 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26fb34f4fb8dab02e0e8c951f1d181e29a702c9e

commit 26fb34f4fb8dab02e0e8c951f1d181e29a702c9e
Author: Colin Blundell <blundell@chromium.org>
Date: Tue Sep 25 09:51:15 2018

[Password autofill] Disable flaky test

See  https://crbug.com/887745  for FindIt's (and my) analysis of the
flake.

TBR=vasilii@chromium.org

Bug:  887745 , 849582
Change-Id: I8c6e520679d7462eb759526d14a375ed05f5503f
Reviewed-on: https://chromium-review.googlesource.com/1242945
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593881}
[modify] https://crrev.com/26fb34f4fb8dab02e0e8c951f1d181e29a702c9e/chrome/browser/password_manager/password_manager_interactive_uitest.cc

Status: Fixed (was: Started)
Sorry for the late reply here. blundell@'s diagnosis in c#3 is correct: my CL didn't change any behavior on tests that were already running; it simply stopped running tests for autofill dropdown native views disabled. The flakiness already existed and was surfaced by my CL. Thanks for disabling it, Colin!

Sign in to add a comment