New issue
Advanced search Search tips

Issue 887744 link

Starred by 1 user
Status: Fixed
Owner:
cassew@google.com
Closed: Jan 17
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

[VR Browsing All-in-One device] Microphone icon remains after denying microphone access, but doesn't work.

Project Member Reported by dbbrooks@chromium.org, Sep 20 
Chrome Version: 71.0.3557.0
OS: O
Device: Lenovo Daydream All-in-One headset

What steps will reproduce the problem?
(1) Fresh install Chrome, or clear all data to reset Chrome.
(2) Open Chrome to start VR Browsing
(3) Click on Omnibox, and then the microphone icon in the Omnibox
(4) A permissions dialog appears asking to allow or deny Chrome to record audio. Click deny.
(5) Click the microphone icon again, and this time a check box appears providing the option to not ask again. Select it, and then select deny.

What is the expected result? The microphone icon should be hidden after permanently denying permission for Chrome to record audio.

What happens instead? The microphone icon remains, clicking on it does nothing. (except briefly resets the cursor position)

Comment 1 by dbbrooks@chromium.org, Nov 5

Summary: [VR Browsing All-in-One device] Microphone icon remains after denying microphone access, but doesn't work. (was: [VR Browsing All-in-One device] Microphone icon remains after denying microphone access)

Comment 2 by btebbs@google.com, Nov 27

Owner: dbbrooks@chromium.org
Do we know if this ever worked?

Comment 3 by dbbrooks@chromium.org, Nov 28 

In our test history, I can see that I marked this test case "Cancel microphone permission request in Chrome VR" as passed. That was back in M68.

Comment 4 by dbbrooks@chromium.org, Nov 28

Owner: ----

Comment 5 by cassew@google.com, Dec 17

Owner: cassew@google.com
Status: Started (was: Untriaged)
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 17 (5 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08734a9ed9f4176d88d47d472ac4947c062c63d2

commit 08734a9ed9f4176d88d47d472ac4947c062c63d2
Author: Will Cassella <cassew@google.com>
Date: Thu Jan 17 23:11:54 2019

Microphone now hidden when record audio permission permanently denied.

Piped permission callback back into C++ VrShell so that permanent-denial
case can be detected.

Bug:  887744 
Change-Id: I9a2f4200cbca52d7c6341c98a98619eb69b0f529
Reviewed-on: https://chromium-review.googlesource.com/c/1412624
Commit-Queue: Will Cassella <cassew@google.com>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623896}
[modify] https://crrev.com/08734a9ed9f4176d88d47d472ac4947c062c63d2/chrome/android/java/src/org/chromium/chrome/browser/vr/VrShell.java
[modify] https://crrev.com/08734a9ed9f4176d88d47d472ac4947c062c63d2/chrome/android/java/src/org/chromium/chrome/browser/vr/VrShellDelegate.java
[modify] https://crrev.com/08734a9ed9f4176d88d47d472ac4947c062c63d2/chrome/browser/android/vr/vr_gl_thread.cc
[modify] https://crrev.com/08734a9ed9f4176d88d47d472ac4947c062c63d2/chrome/browser/android/vr/vr_gl_thread.h
[modify] https://crrev.com/08734a9ed9f4176d88d47d472ac4947c062c63d2/chrome/browser/android/vr/vr_shell.cc
[modify] https://crrev.com/08734a9ed9f4176d88d47d472ac4947c062c63d2/chrome/browser/android/vr/vr_shell.h
[modify] https://crrev.com/08734a9ed9f4176d88d47d472ac4947c062c63d2/chrome/browser/vr/browser_ui_interface.h
[modify] https://crrev.com/08734a9ed9f4176d88d47d472ac4947c062c63d2/chrome/browser/vr/model/model.cc
[modify] https://crrev.com/08734a9ed9f4176d88d47d472ac4947c062c63d2/chrome/browser/vr/model/model.h
[modify] https://crrev.com/08734a9ed9f4176d88d47d472ac4947c062c63d2/chrome/browser/vr/model/speech_recognition_model.h
[modify] https://crrev.com/08734a9ed9f4176d88d47d472ac4947c062c63d2/chrome/browser/vr/test/mock_browser_ui_interface.h
[modify] https://crrev.com/08734a9ed9f4176d88d47d472ac4947c062c63d2/chrome/browser/vr/testapp/vr_test_context.cc
[modify] https://crrev.com/08734a9ed9f4176d88d47d472ac4947c062c63d2/chrome/browser/vr/ui.cc
[modify] https://crrev.com/08734a9ed9f4176d88d47d472ac4947c062c63d2/chrome/browser/vr/ui.h
[modify] https://crrev.com/08734a9ed9f4176d88d47d472ac4947c062c63d2/chrome/browser/vr/ui_initial_state.h
[modify] https://crrev.com/08734a9ed9f4176d88d47d472ac4947c062c63d2/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/08734a9ed9f4176d88d47d472ac4947c062c63d2/chrome/browser/vr/ui_unittest.cc

Comment 7 by cassew@google.com, Jan 17 (5 days ago)

Status: Fixed (was: Started)
►

Sign in to add a comment