New issue
Advanced search Search tips

Issue 887733 link

Starred by 1 user
Status: Fixed
Owner:
manucornet@chromium.org
Closed: Oct 24
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Top right corner of shelf/system tray looks wrong.

Project Member Reported by xiy...@chromium.org, Sep 20 
Seen on 71.0.3557.0 (r592483)

The top right corner  is not round. Seems like a layer not controlled by the mask gets put there.

And if you change shelf aligntment to left then back to bottom, the top left corner also looks wrong. And the top right corner is wrong in a different way.

Manu, could you help to triage? Thanks.
shelf_corner_align_left_n_back.png
1.1 MB View Download

Comment 1 by xiy...@chromium.org, Sep 20 

Strange. Lost the first screenshot in #0 somehow. 

Here is it. This is what I saw initially (after sign-in) before changing the alignment.

Comment 2 by xiy...@chromium.org, Sep 20

shelf_corner.png
1.1 MB View Download

Comment 3 by newcomer@chromium.org, Sep 25

Labels: M-71

Comment 4 by newcomer@chromium.org, Oct 15

Labels: m-72
Bulk moving all M-71 <P-1's to M-72.

Comment 5 by newcomer@chromium.org, Oct 15

Labels: -M-71 -m-71

Comment 6 by manucornet@chromium.org, Oct 19

Status: Started (was: Assigned)

Comment 8 by manucornet@chromium.org, Oct 24

Status: Fixed (was: Started)
Project Member

Comment 9 by cr-audit...@appspot.gserviceaccount.com, Oct 25

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/62dcf48b9ecd4ac3b24667a133b7c373cc296bb8

Commit: 62dcf48b9ecd4ac3b24667a133b7c373cc296bb8
Author: manucornet@chromium.org
Commiter: manucornet@chromium.org
Date: 2018-10-25 09:41:55 +0000 UTC

CrOS shelf: use translation for auto-hide instead of altering size

TBR=manucornet@chromium.org

(cherry picked from commit ee02be48c59260a48c98ebf3c9a58e1a5dd2b68e)

Bug:  891416 , 886622 , 888205 , 887733 ,881684,822477
Change-Id: Id187d692caf7b9ca8ce4ecee2206dc6420c343c4
Reviewed-on: https://chromium-review.googlesource.com/c/1290056
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#602201}
Reviewed-on: https://chromium-review.googlesource.com/c/1298945
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#314}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
Project Member

Comment 10 by bugdroid1@chromium.org, Oct 25

Labels: merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/62dcf48b9ecd4ac3b24667a133b7c373cc296bb8

commit 62dcf48b9ecd4ac3b24667a133b7c373cc296bb8
Author: Manu Cornet <manucornet@chromium.org>
Date: Thu Oct 25 09:41:55 2018

CrOS shelf: use translation for auto-hide instead of altering size

TBR=manucornet@chromium.org

(cherry picked from commit ee02be48c59260a48c98ebf3c9a58e1a5dd2b68e)

Bug:  891416 , 886622 , 888205 , 887733 ,881684,822477
Change-Id: Id187d692caf7b9ca8ce4ecee2206dc6420c343c4
Reviewed-on: https://chromium-review.googlesource.com/c/1290056
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#602201}
Reviewed-on: https://chromium-review.googlesource.com/c/1298945
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#314}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/62dcf48b9ecd4ac3b24667a133b7c373cc296bb8/ash/shelf/shelf_constants.h
[modify] https://crrev.com/62dcf48b9ecd4ac3b24667a133b7c373cc296bb8/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/62dcf48b9ecd4ac3b24667a133b7c373cc296bb8/ash/shelf/shelf_layout_manager.h
[modify] https://crrev.com/62dcf48b9ecd4ac3b24667a133b7c373cc296bb8/ash/shelf/shelf_layout_manager_unittest.cc
[modify] https://crrev.com/62dcf48b9ecd4ac3b24667a133b7c373cc296bb8/ash/shelf/shelf_widget.cc
[modify] https://crrev.com/62dcf48b9ecd4ac3b24667a133b7c373cc296bb8/ash/system/toast/toast_manager_unittest.cc
►

Sign in to add a comment