git cl upload in src hangs after finishing |
||||||
Issue description
When I run git cl upload in chromium/src, I see the following:
"
$ git cl upload -m 'Unflake test'
Running presubmit upload checks ...
Presubmit checks took 7.5s to calculate.
Presubmit checks passed.
testing/buildbot/PRESUBMIT.py | 3 ++-
testing/buildbot/generate_buildbot_json.py | 20 ++++++++++-----
testing/buildbot/generate_buildbot_json_unittest.py | 162 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------
3 files changed, 130 insertions(+), 55 deletions(-)
remote: Processing changes: refs: 1, updated: 1, done
remote: commit da15329: (W) da15329: commit subject >50 characters; use shorter first paragraph
remote: warning: no changes between prior commit 8160f5d and new commit da15329
remote:
remote: SUCCESS
remote:
remote: Updated Changes:
remote: https://chromium-review.googlesource.com/c/chromium/src/+/1237239 generate_buildbot_json.py: Better handle printed lines
remote:
To https://chromium.googlesource.com/chromium/src.git
* [new branch] da15329ebc7a5f1713f101ca26552559c46c0f1b -> refs/for/refs/heads/master%notify=NONE,m=Unflake_test
^C^\[1] 248489 quit git cl upload -m 'Unflake test'
"
The last line is me hitting C-/, which kills the program. I tried Ctrl+C, but that didn't do anything.
I've seen this a few times. Not sure what the best component is.
,
Sep 20
This hasn't happened the last two times I uploaded code, FYI.
,
Sep 20
,
Sep 20
,
Sep 20
FWIW sometimes it hangs (or just super slow) before uploading too.
,
Sep 21
,
Sep 21
assign -> ajp on tandrii's recommendation :) (sorry if that's the wrong thing, but I think it's potentially related to other issues you're working on with gob folks?)
,
Sep 24
Not sure what to do with this bug, hopefully answers to a few questions will help with that. @nodir, @martiniss: * Are you seeing any other error messages, especially a 404, from git upload? That's what the (potentially related) issue is around. If not, I'm not sure (yet) how they'd be related. * When it does happen, after you Ctrl+\ what state is the CL upload in at the end? Did the upload complete successfully? * Does it happen consistently? Does retrying solve the problem? Any other details appreciated.
,
Sep 24
1. I don't think I saw a 404... The log in the description is what I saw, and I think the others looked like that. I don't think I saw any other error messages when I saw it other times IIRC. 2. I think the upload succeeds; there are two patch sets with the name 'Unflake test' in the CL in the description. So I think it worked, but hung after the upload succeeded somehow. 3. I think retrying fixed it. It hasn't happened again for me today, so I'm not sure if that always works.
,
Sep 27
I'm not hearing more reports or indication that this was a persistent problem. I'm going to downgrade this to p2 for now. I also hope that our significant rewrite of the requests sent by git cl upload that is in progress to fix https://crbug.com/881860 will also help improve what's happening here but that's a wild hope. If this happens again and you can run git cl upload in verbose mode to provide more information on what's going on that would be very helpful.
,
Oct 1
My 2c, I've been getting a lot of 404s and other errors from git cl upload in the last week or two, including some today. I asked and other people nearby are also seeing this. Is there anything I can capture to help debug this?
,
Oct 1
@fergal - The 404s from git cl upload are separate p1 issue, https://crbug.com/881860. We have a planned solution that people are actively working on. If you get output from git cl upload that asks you to upload it please do so. We've done a bit of that to help get root cause debugging information. What errors other than 404s are you seeing?
,
Oct 1
> If you get output from git cl upload that asks you to upload it please do so Is there an "always upload debug info" settings I can set somewhere? > What errors other than 404s are you seeing? I feel like I saw others but I don't know for sure. If I get some, I will let you know.
,
Oct 2
There is not a setting about uploading debug info, but it's a good idea. If nothing else we do need more monitoring in these tools, which I will be putting on our roadmap.
,
Oct 5
The other errors I've seen are 503. I've filed https://crbug.com/892488 since it seems like a very different issue. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by no...@chromium.org
, Sep 20