[Print preview refresh] Additional padding changes in Print preview |
|
Issue description1. Reduce the padding between check box and Options under Advanced settings to 8px. 2. Reduce the padding between checkbox and collate to 8px
,
Sep 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5e659696b565b65c4b89a2d117c8b4dba5cf30f9 commit 5e659696b565b65c4b89a2d117c8b4dba5cf30f9 Author: rbpotter <rbpotter@chromium.org> Date: Sat Sep 22 01:13:17 2018 Print Preview Refresh: Fix some spacing issues (1) For cr-input: Do not apply cr row container mixin to inner div. This was done accidentally while adding the prefix slot. (2) Adjust heights/margins so that collate checkbox ripple is not cut off and collate does not cause the copies section to shift when it appears. (3) Ensure collate breaks the word if it is too large, to fix possible issues with large font sizes/languages where "collate" translates to something with a very long word. (4) Reduce checkbox padding - this helps with collate and aligns with UX request to reduce checkbox padding to as little as possible, without cutting off the ripple. (5) Add margin-top: 16 for settings sections, which allows extra padding applied to more-settings when expanded to be removed (fixes animation issue). Bug: 887837 , 887839 , 887704 Change-Id: I9d3a9bc468ce0ee5b4a2ecfb136233d3a1054902 Reviewed-on: https://chromium-review.googlesource.com/1239333 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#593403} [modify] https://crrev.com/5e659696b565b65c4b89a2d117c8b4dba5cf30f9/chrome/browser/resources/print_preview/new/copies_settings.html [modify] https://crrev.com/5e659696b565b65c4b89a2d117c8b4dba5cf30f9/chrome/browser/resources/print_preview/new/more_settings.html [modify] https://crrev.com/5e659696b565b65c4b89a2d117c8b4dba5cf30f9/chrome/browser/resources/print_preview/new/more_settings.js [modify] https://crrev.com/5e659696b565b65c4b89a2d117c8b4dba5cf30f9/chrome/browser/resources/print_preview/new/number_settings_section.html [modify] https://crrev.com/5e659696b565b65c4b89a2d117c8b4dba5cf30f9/chrome/browser/resources/print_preview/new/other_options_settings.html [modify] https://crrev.com/5e659696b565b65c4b89a2d117c8b4dba5cf30f9/chrome/browser/resources/print_preview/new/print_preview_shared_css.html [modify] https://crrev.com/5e659696b565b65c4b89a2d117c8b4dba5cf30f9/chrome/browser/resources/print_preview/new/settings_section.html [modify] https://crrev.com/5e659696b565b65c4b89a2d117c8b4dba5cf30f9/ui/webui/resources/cr_elements/cr_input/cr_input.html |
|
►
Sign in to add a comment |
|
Comment 1 by rbpotter@chromium.org
, Sep 20