New issue
Advanced search Search tips

Issue 887700 link

Starred by 1 user
Status: Fixed
Owner:
johnidel@chromium.org
Closed: Oct 9
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add UKM for ad page loads

Project Member Reported by johnidel@chromium.org, Sep 20 
Add UKM for existing UMA metrics on the amount of bytes of ads on pages. Metrics that should be included are: total page bytes, ad bytes, ad videos bytes, ad javascript bytes, ad bytes per second. These will allow us to manually inspect some sites to see what types of resources / ads are causing large amounts of data use.
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c4ead6ae8347d602d32b2e419aed9490dce4abd

commit 3c4ead6ae8347d602d32b2e419aed9490dce4abd
Author: John Delaney <johnidel@chromium.org>
Date: Tue Oct 09 15:39:07 2018

Add UKM metrics for ad page load

Add UKM for some existing UMA metrics in AdsPageLoadMetricsBbserver. Add new
metric for ad bytes over time. These UKM metrics will help identify
sites using large amounts of network bytes for loading ads. Will allow
us to investigate what these sites are doing that uses so much data.

Bug:  887700 
Change-Id: I0fa6f9ce5a1ea7e2cf826db10ed887d3e8791c69
Reviewed-on: https://chromium-review.googlesource.com/c/1240168
Commit-Queue: John Delaney <johnidel@chromium.org>
Reviewed-by: Josh Karlin <jkarlin@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597923}
[modify] https://crrev.com/3c4ead6ae8347d602d32b2e419aed9490dce4abd/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.cc
[modify] https://crrev.com/3c4ead6ae8347d602d32b2e419aed9490dce4abd/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer.h
[modify] https://crrev.com/3c4ead6ae8347d602d32b2e419aed9490dce4abd/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_browsertest.cc
[modify] https://crrev.com/3c4ead6ae8347d602d32b2e419aed9490dce4abd/chrome/browser/page_load_metrics/observers/ads_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/3c4ead6ae8347d602d32b2e419aed9490dce4abd/tools/metrics/ukm/ukm.xml

Comment 2 by johnidel@chromium.org, Oct 9

Status: Fixed (was: Started)
►

Sign in to add a comment