New issue
Advanced search Search tips

Issue 887688 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 21
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Crash from networkingPrivate.getNetworks responding with invalid json

Project Member Reported by jdufault@chromium.org, Sep 20

Issue description

The following crash happens during enterprise enrollment and also when on sign-on screen.

[1:1:0920/125654.735772:FATAL:api_response_validator.cc(75)] Check failed: false. Error validating response to networkingPrivate.getNetworks: Error at parameter 'result': Error at index 8: Error at property 'WiFi': Unexpected property: 'EAP'.

The relevant JSON failing the check is
{
   "Connectable": false,
   "ConnectionState": "NotConnected",
   "GUID": "{3e5dc63d-06e3-40d6-a78f-b20bc52a2c7b}",
   "Name": "hendrich_PEAP_test",
   "Priority": 0,
   "Source": "DevicePolicy",
   "Type": "WiFi",
   "WiFi": {
      "BSSID": "",
      "EAP": {
         "Outer": "PEAP"
      },
      "Frequency": 0,
      "HexSSID": "68656E64726963685F504541505F74657374",
      "SSID": "hendrich_PEAP_test",
      "Security": "WPA-EAP",
      "SignalStrength": 1,
      "TetheringState": ""
   }
}

getNetworks returns NetworkStateProperties[], which has a WifiStateProperties, which does not have an EAP property

network->GetStateProperties() is returning a dict with "EAP.EAP" https://cs.chromium.org/chromium/src/chromeos/network/network_state.cc?l=296&rcl=144854454b206cbe9c191e51b905c1d6bf01e72e

To fix, from stevenjb@,

  OK. We just need to include EAP.Outer in the IDL signature, i.e.:
    dictionary EAPStateProperties {
      DOMString? Outer;
  }
  Then add to WiFiStateProperties:
  EAPStateProperties? EAP;
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ebc6870a84db9a49bdef9f507d0045e5d355377

commit 3ebc6870a84db9a49bdef9f507d0045e5d355377
Author: Jacob Dufault <jdufault@google.com>
Date: Thu Sep 20 23:51:16 2018

cros: Fix networkingPrivate.getNetworks IDL validation error

The IDL file did not fully specify all of the output.

Bug:  887688 
Change-Id: I5ee75419006a27504e978164379acf7c024988db
Reviewed-on: https://chromium-review.googlesource.com/1237374
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593004}
[modify] https://crrev.com/3ebc6870a84db9a49bdef9f507d0045e5d355377/extensions/common/api/networking_private.idl

Status: Fixed (was: Assigned)

Sign in to add a comment