New issue
Advanced search Search tips

Issue 887680 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Tab hangs when there's outstanding cookie requests and the network service crashes

Project Member Reported by jam@chromium.org, Sep 20

Issue description

Loading gmail and killing the network service hangs that tab. It's because the CookieManager has pending requests.
 
Description: Show this description

Comment 2 Deleted

Project Member

Comment 3 by bugdroid1@chromium.org, Sep 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1f61a5fd79eabc30a40d45cb9c524be7d751f6d2

commit 1f61a5fd79eabc30a40d45cb9c524be7d751f6d2
Author: John Abd-El-Malek <jam@chromium.org>
Date: Fri Sep 21 01:13:14 2018

Fix JS cookie access failing or hanging after network process crashes.

Bug:  887680 
Change-Id: I249e640a559e550b879370f2f02d2437e52ac93b
Reviewed-on: https://chromium-review.googlesource.com/1236282
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Chong Zhang <chongz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593038}
[modify] https://crrev.com/1f61a5fd79eabc30a40d45cb9c524be7d751f6d2/content/browser/frame_host/render_frame_message_filter.cc
[modify] https://crrev.com/1f61a5fd79eabc30a40d45cb9c524be7d751f6d2/content/browser/frame_host/render_frame_message_filter.h
[modify] https://crrev.com/1f61a5fd79eabc30a40d45cb9c524be7d751f6d2/content/browser/network_service_restart_browsertest.cc

Labels: Merge-Request-70
Project Member

Comment 5 by sheriffbot@chromium.org, Sep 21

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: benmason@chromium.org
NextAction: 2018-09-24
This hasn't made it to canary yet. Let's follow up on Monday.
NextAction: ----
jam@ let me know this *will* affect Android at some point, but not at the moment. I'll let desktop decide on the merge here.
Labels: -Merge-Review-70 Merge-Approved-70
Project Member

Comment 10 by bugdroid1@chromium.org, Sep 21

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7acdf3be63e60e17345b1eb7afbb7f1d5978602b

commit 7acdf3be63e60e17345b1eb7afbb7f1d5978602b
Author: John Abd-El-Malek <jam@chromium.org>
Date: Fri Sep 21 22:32:13 2018

Fix JS cookie access failing or hanging after network process crashes.

TBR=jam@chromium.org

(cherry picked from commit 1f61a5fd79eabc30a40d45cb9c524be7d751f6d2)

Bug:  887680 
Change-Id: I249e640a559e550b879370f2f02d2437e52ac93b
Reviewed-on: https://chromium-review.googlesource.com/1236282
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Chong Zhang <chongz@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#593038}
Reviewed-on: https://chromium-review.googlesource.com/1238483
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#571}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/7acdf3be63e60e17345b1eb7afbb7f1d5978602b/content/browser/frame_host/render_frame_message_filter.cc
[modify] https://crrev.com/7acdf3be63e60e17345b1eb7afbb7f1d5978602b/content/browser/frame_host/render_frame_message_filter.h
[modify] https://crrev.com/7acdf3be63e60e17345b1eb7afbb7f1d5978602b/content/browser/network_service_restart_browsertest.cc

Labels: Merge-Merged-70-3538
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/7acdf3be63e60e17345b1eb7afbb7f1d5978602b

Commit: 7acdf3be63e60e17345b1eb7afbb7f1d5978602b
Author: jam@chromium.org
Commiter: jam@chromium.org
Date: 2018-09-21 22:32:13 +0000 UTC

Fix JS cookie access failing or hanging after network process crashes.

TBR=jam@chromium.org

(cherry picked from commit 1f61a5fd79eabc30a40d45cb9c524be7d751f6d2)

Bug:  887680 
Change-Id: I249e640a559e550b879370f2f02d2437e52ac93b
Reviewed-on: https://chromium-review.googlesource.com/1236282
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Chong Zhang <chongz@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#593038}
Reviewed-on: https://chromium-review.googlesource.com/1238483
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#571}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
Status: Fixed (was: Started)

Sign in to add a comment