New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 887678 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Style the explicit ask list correctly.

Project Member Reported by anthonyvd@chromium.org, Sep 20

Issue description

The list should look like the specs at go/india-explicit-language-ask-specs
 
The first patchset of https://chromium-review.googlesource.com/c/chromium/src/+/1237178 makes the list look like the attached file.
Screenshot from 2018-09-20 17-10-00.png
43.0 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e10f8efa24aebf84c7f2c3ca750ca3e3efd0678b

commit e10f8efa24aebf84c7f2c3ca750ca3e3efd0678b
Author: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Date: Mon Sep 24 20:37:49 2018

Format the language list in Explicit Ask Prompt

This patch aligns the checkboxes to the first text line and adds a
separator between the geo/accept languages and the rest of the list.

Bug:  887678 
Change-Id: Icf0f20a2f550541cd940d134b752d0d5deee6f11
Reviewed-on: https://chromium-review.googlesource.com/1237178
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593666}
[modify] https://crrev.com/e10f8efa24aebf84c7f2c3ca750ca3e3efd0678b/chrome/android/java/res/layout/language_ask_prompt_row.xml
[add] https://crrev.com/e10f8efa24aebf84c7f2c3ca750ca3e3efd0678b/chrome/android/java/res/layout/language_ask_prompt_row_separator.xml
[modify] https://crrev.com/e10f8efa24aebf84c7f2c3ca750ca3e3efd0678b/chrome/android/java/src/org/chromium/chrome/browser/language/LanguageAskPrompt.java

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 1

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/79a0906ae9a789599820b7fb543d5ab997272a0c

commit 79a0906ae9a789599820b7fb543d5ab997272a0c
Author: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Date: Mon Oct 01 19:29:34 2018

Explicit Language Ask minor UI polish

This adds a bit of padding after the checkboxes and makes entire
rows clickable.

Bug:  887678 
Change-Id: I89d6d7f1901170d6178b3b5e0fce228b3d584d00
Reviewed-on: https://chromium-review.googlesource.com/1252524
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595501}
[modify] https://crrev.com/79a0906ae9a789599820b7fb543d5ab997272a0c/chrome/android/java/res/layout/language_ask_prompt_row.xml
[modify] https://crrev.com/79a0906ae9a789599820b7fb543d5ab997272a0c/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/79a0906ae9a789599820b7fb543d5ab997272a0c/chrome/android/java/src/org/chromium/chrome/browser/language/LanguageAskPrompt.java

Status: Started (was: Untriaged)
Labels: Merge-Request-70
Requesting merge for the CLs in #2 and #3. They are small UI tweaks that are gated behind a disabled-by-default Finch experiment.
Project Member

Comment 6 by sheriffbot@chromium.org, Oct 2

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: We are only 13 days from stable.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Hotlist-Merge-Review -Merge-Review-70 Merge-Approved-70
Approved for merge to 70, branch 3538.
Status: Fixed (was: Started)
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 2

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/098740877240ca4137bddbb59b5c03e851f90792

commit 098740877240ca4137bddbb59b5c03e851f90792
Author: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Date: Tue Oct 02 17:54:20 2018

Format the language list in Explicit Ask Prompt

This patch aligns the checkboxes to the first text line and adds a
separator between the geo/accept languages and the rest of the list.

Bug:  887678 
Change-Id: Icf0f20a2f550541cd940d134b752d0d5deee6f11
Reviewed-on: https://chromium-review.googlesource.com/1237178
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#593666}(cherry picked from commit e10f8efa24aebf84c7f2c3ca750ca3e3efd0678b)
Reviewed-on: https://chromium-review.googlesource.com/c/1257622
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#820}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/098740877240ca4137bddbb59b5c03e851f90792/chrome/android/java/res/layout/language_ask_prompt_row.xml
[add] https://crrev.com/098740877240ca4137bddbb59b5c03e851f90792/chrome/android/java/res/layout/language_ask_prompt_row_separator.xml
[modify] https://crrev.com/098740877240ca4137bddbb59b5c03e851f90792/chrome/android/java/src/org/chromium/chrome/browser/language/LanguageAskPrompt.java

Project Member

Comment 10 by bugdroid1@chromium.org, Oct 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d610d99898ebb3dd85760a4956a587348e6e56e9

commit d610d99898ebb3dd85760a4956a587348e6e56e9
Author: Anthony Vallee-Dubois <anthonyvd@chromium.org>
Date: Tue Oct 02 17:55:02 2018

Explicit Language Ask minor UI polish

This adds a bit of padding after the checkboxes and makes entire
rows clickable.

Bug:  887678 
Change-Id: I89d6d7f1901170d6178b3b5e0fce228b3d584d00
Reviewed-on: https://chromium-review.googlesource.com/1252524
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#595501}(cherry picked from commit 79a0906ae9a789599820b7fb543d5ab997272a0c)
Reviewed-on: https://chromium-review.googlesource.com/c/1257623
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#821}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/d610d99898ebb3dd85760a4956a587348e6e56e9/chrome/android/java/res/layout/language_ask_prompt_row.xml
[modify] https://crrev.com/d610d99898ebb3dd85760a4956a587348e6e56e9/chrome/android/java/res/values/dimens.xml
[modify] https://crrev.com/d610d99898ebb3dd85760a4956a587348e6e56e9/chrome/android/java/src/org/chromium/chrome/browser/language/LanguageAskPrompt.java

Labels: Merge-Merged-70-3538
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/098740877240ca4137bddbb59b5c03e851f90792

Commit: 098740877240ca4137bddbb59b5c03e851f90792
Author: anthonyvd@chromium.org
Commiter: anthonyvd@chromium.org
Date: 2018-10-02 17:54:20 +0000 UTC

Format the language list in Explicit Ask Prompt

This patch aligns the checkboxes to the first text line and adds a
separator between the geo/accept languages and the rest of the list.

Bug:  887678 
Change-Id: Icf0f20a2f550541cd940d134b752d0d5deee6f11
Reviewed-on: https://chromium-review.googlesource.com/1237178
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#593666}(cherry picked from commit e10f8efa24aebf84c7f2c3ca750ca3e3efd0678b)
Reviewed-on: https://chromium-review.googlesource.com/c/1257622
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#820}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/d610d99898ebb3dd85760a4956a587348e6e56e9

Commit: d610d99898ebb3dd85760a4956a587348e6e56e9
Author: anthonyvd@chromium.org
Commiter: anthonyvd@chromium.org
Date: 2018-10-02 17:55:02 +0000 UTC

Explicit Language Ask minor UI polish

This adds a bit of padding after the checkboxes and makes entire
rows clickable.

Bug:  887678 
Change-Id: I89d6d7f1901170d6178b3b5e0fce228b3d584d00
Reviewed-on: https://chromium-review.googlesource.com/1252524
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#595501}(cherry picked from commit 79a0906ae9a789599820b7fb543d5ab997272a0c)
Reviewed-on: https://chromium-review.googlesource.com/c/1257623
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#821}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}

Sign in to add a comment