New issue
Advanced search Search tips

Issue 887677 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 21
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

NetworkFileShares UI: Switch to sentence case

Project Member Reported by baileyberro@chromium.org, Sep 20

Issue description

Currently there are a few spots where we don't use sentence case in the Network file shares settings page.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6291ed11a6b41294b2c31ac99c1eb11026805a5a

commit 6291ed11a6b41294b2c31ac99c1eb11026805a5a
Author: Bailey Berro <baileyberro@chromium.org>
Date: Fri Sep 21 20:07:49 2018

Change Network file shares to sentence casing

- Switches Network file shares settings page to using sentence casing.

Bug:  chromium:887677 
Change-Id: If7bffe4d4b9ffdf464e1d81d782c0a4033b3fb1a
Reviewed-on: https://chromium-review.googlesource.com/1237393
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593313}
[modify] https://crrev.com/6291ed11a6b41294b2c31ac99c1eb11026805a5a/chrome/app/settings_strings.grdp

Status: Fixed (was: Started)
Labels: -M-71 Merge-Request-70 M-70
Project Member

Comment 4 by sheriffbot@chromium.org, Sep 24

Labels: -Merge-Request-70 Merge-Review-70 Hotlist-Merge-Review
This bug requires manual review: There is .grd file changes and we are only 21 days from stable.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-70 Merge-Approved-70
Project Member

Comment 6 by bugdroid1@chromium.org, Sep 25

Labels: -merge-approved-70 merge-merged-3538
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9aed87faed07186d8fb129e4ff2185f84b537732

commit 9aed87faed07186d8fb129e4ff2185f84b537732
Author: Bailey Berro <baileyberro@chromium.org>
Date: Tue Sep 25 22:50:17 2018

Change Network file shares to sentence casing

- Switches Network file shares settings page to using sentence casing.

Bug:  chromium:887677 
Change-Id: If7bffe4d4b9ffdf464e1d81d782c0a4033b3fb1a
Reviewed-on: https://chromium-review.googlesource.com/1237393
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#593313}(cherry picked from commit 6291ed11a6b41294b2c31ac99c1eb11026805a5a)
Reviewed-on: https://chromium-review.googlesource.com/1244820
Cr-Commit-Position: refs/branch-heads/3538@{#672}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/9aed87faed07186d8fb129e4ff2185f84b537732/chrome/app/settings_strings.grdp

Sign in to add a comment