New issue
Advanced search Search tips

Issue 887663 link

Starred by 1 user
Status: WontFix
Owner:
est...@chromium.org
Closed: Oct 17
Cc:
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

ash::FrameBackButton doesn't work in Mash

Project Member Reported by est...@chromium.org, Sep 20 
FrameBackButton wouldn't work if run in the client in Mash. Currently in Mash, it's always running in Ash (//chrome/browser/ uses it in classic Ash but not Mash). So it might be sufficient to remove it from //ash/public/ so it's not accidentally used from Chrome.

Comment 1 by zalcorn@chromium.org, Sep 28 

Triage nag: This Chrome OS bug has an owner but no component. Please add a component so that this can be tracked by the relevant team.

Comment 2 by est...@chromium.org, Oct 1

Components: Internals>Services>Ash
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0860c04e483d3e1c3d3f7d0e850b3498d56952fa

commit 0860c04e483d3e1c3d3f7d0e850b3498d56952fa
Author: Evan Stade <estade@chromium.org>
Date: Mon Oct 08 17:19:29 2018

Remove TODO for ash::FrameBackButton

Bug:  887663 
Change-Id: I0e5d3e16d59cf3459fde94f3ed2edb23c2ea9f0e
Reviewed-on: https://chromium-review.googlesource.com/c/1260002
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597593}
[modify] https://crrev.com/0860c04e483d3e1c3d3f7d0e850b3498d56952fa/ash/public/cpp/caption_buttons/frame_back_button.cc

Comment 4 by est...@chromium.org, Oct 17

Status: WontFix (was: Assigned)
►

Sign in to add a comment