Animation Worklet - enable animation worklet tests to run on main thread |
||||||
Issue descriptionWe now have basic WorkletAnimation support for slow property. We should start running all AW tests on both fast and slow path.
,
Sep 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f654b07812cf771043806cdb4b5e1c0aa7cda64 commit 1f654b07812cf771043806cdb4b5e1c0aa7cda64 Author: liberato@chromium.org <liberato@chromium.org> Date: Fri Sep 21 21:53:25 2018 [Sherrif] Disable worklet-animation-responsive-to-zoom.html It wasn't included in TestExpectations by https://chromium-review.googlesource.com/c/chromium/src/+/1237235 but it looks like it failed all the same. NOTRY=true TBR=majidvp@chromium.org Bug: 887659 Change-Id: Iabb8204a4b4b05515838cf20378e61d07062ea51 Reviewed-on: https://chromium-review.googlesource.com/1239446 Reviewed-by: Frank Liberato <liberato@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#593345} [modify] https://crrev.com/1f654b07812cf771043806cdb4b5e1c0aa7cda64/third_party/WebKit/LayoutTests/TestExpectations
,
Sep 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ddefc706472b2b1107208be1ec9d8a3b79fbd70 commit 6ddefc706472b2b1107208be1ec9d8a3b79fbd70 Author: Fredrik Söderquist <fs@opera.com> Date: Sat Sep 22 08:26:41 2018 Revert "[Sherrif] Disable worklet-animation-responsive-to-zoom.html" This reverts commit 1f654b07812cf771043806cdb4b5e1c0aa7cda64. Reason for revert: This test was reverted by https://chromium-review.googlesource.com/c/chromium/src/+/1239773 causing presubmits to fail. Original change's description: > [Sherrif] Disable worklet-animation-responsive-to-zoom.html > > It wasn't included in TestExpectations by > > https://chromium-review.googlesource.com/c/chromium/src/+/1237235 > > but it looks like it failed all the same. > > NOTRY=true > TBR=majidvp@chromium.org > > Bug: 887659 > Change-Id: Iabb8204a4b4b05515838cf20378e61d07062ea51 > Reviewed-on: https://chromium-review.googlesource.com/1239446 > Reviewed-by: Frank Liberato <liberato@chromium.org> > Commit-Queue: Frank Liberato <liberato@chromium.org> > Cr-Commit-Position: refs/heads/master@{#593345} TBR=majidvp@chromium.org,liberato@chromium.org Change-Id: I6bb03b3d8d78f3c7c66132656f00f32ee36e9a21 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 887659 Reviewed-on: https://chromium-review.googlesource.com/1238916 Reviewed-by: Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#593437} [modify] https://crrev.com/6ddefc706472b2b1107208be1ec9d8a3b79fbd70/third_party/WebKit/LayoutTests/TestExpectations
,
Sep 24
ClusterFuzz also identified two crashes (see issue 888206 ) when this was landed. We should make sure to fix those when re-landing.
,
Oct 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/582b7bb5feebc2324793077332cfe86ab845a09e commit 582b7bb5feebc2324793077332cfe86ab845a09e Author: Majid Valipour <majidvp@chromium.org> Date: Thu Oct 04 16:45:21 2018 [animation-worklet] move layout tests to new directory Bug: 887659 Change-Id: I6b201d3eb3e75bbdc56429228d82e72830a96709 Reviewed-on: https://chromium-review.googlesource.com/c/1261981 Reviewed-by: Xida Chen <xidachen@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#596706} [rename] https://crrev.com/582b7bb5feebc2324793077332cfe86ab845a09e/third_party/WebKit/LayoutTests/animations/animationworklet/worklet-animation-with-invalid-effect.html
,
Oct 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1d9156323a9b236846a9bfe45643a4c2d39fc988 commit 1d9156323a9b236846a9bfe45643a4c2d39fc988 Author: Majid Valipour <majidvp@chromium.org> Date: Fri Oct 05 18:13:44 2018 [animation-worklet] Fix crash in tests when running on main thread Worklet animation supports invalidation of its compositing state. This patch makes this invalidation process a no-op for animations that are running on main (i.e., |compositor_animation_| is null). This means we no longer try to read/modify the non-existent |compositor_animation_| which was causing the crash. Note that in some situations, even for currently main thread animaiton, we may actually want to create and start the |compositor_animation_| but this is a separate issue that can be fixed as a follow up. The added DCHECK uncovered a bug where we were attaching the worklet animation to early even if play was failing. This is also fixed. Bug: 887659 , 889330 Change-Id: I4a89de6632e053f68beafb810355c25e4bfba0e3 Reviewed-on: https://chromium-review.googlesource.com/c/1249387 Commit-Queue: Majid Valipour <majidvp@chromium.org> Reviewed-by: Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#597199} [modify] https://crrev.com/1d9156323a9b236846a9bfe45643a4c2d39fc988/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/1d9156323a9b236846a9bfe45643a4c2d39fc988/third_party/blink/renderer/modules/animationworklet/worklet_animation.cc
,
Oct 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a8ded33693c5aceb941ea978411dcaf17f0e62b4 commit a8ded33693c5aceb941ea978411dcaf17f0e62b4 Author: Majid Valipour <majidvp@chromium.org> Date: Sat Oct 13 00:33:10 2018 [animation-worklet] Do not create console message when compositing fails This patch removes the warning message we log when animations are not composited. Chatting with flackr@, we think that having a devtools warning is not the intention of these messages and we should surface them elsewhere in devtools as we should do for all other animations. Prior to this change some of our tests had a different console output whether running on fast path or slow path. This meant that some tests appeared to be failing when running on slow path since they were producing additional console output that was not in the expectation file. With the change, the output for tests running with or w/o the flag is the same so they pass. Bug= 887659 Change-Id: Ia9ee5b6037f20e818339d89daba19889c8a817de Reviewed-on: https://chromium-review.googlesource.com/c/1249522 Reviewed-by: Majid Valipour <majidvp@chromium.org> Reviewed-by: Yi Gu <yigu@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#599440} [modify] https://crrev.com/a8ded33693c5aceb941ea978411dcaf17f0e62b4/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/a8ded33693c5aceb941ea978411dcaf17f0e62b4/third_party/WebKit/LayoutTests/animations/animationworklet/animate-multiple-effects-via-main-thread-expected.txt [modify] https://crrev.com/a8ded33693c5aceb941ea978411dcaf17f0e62b4/third_party/WebKit/LayoutTests/animations/animationworklet/animate-non-accelerated-property-expected.txt [modify] https://crrev.com/a8ded33693c5aceb941ea978411dcaf17f0e62b4/third_party/WebKit/LayoutTests/animations/animationworklet/cancel-non-accelerated-property-expected.txt [modify] https://crrev.com/a8ded33693c5aceb941ea978411dcaf17f0e62b4/third_party/blink/renderer/modules/animationworklet/worklet_animation.cc [modify] https://crrev.com/a8ded33693c5aceb941ea978411dcaf17f0e62b4/third_party/blink/renderer/modules/animationworklet/worklet_animation.h
,
Oct 18
I'm gonna fix the test failures on main thread.
,
Oct 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ce818d5024db8e242512d817f66b99b76096a4c9 commit ce818d5024db8e242512d817f66b99b76096a4c9 Author: Yi Gu <yigu@chromium.org> Date: Thu Oct 18 18:56:03 2018 [animation worklet] Use NaN to represent unresolved inherited time Previously we use 0 as inherited time for worklet animations because the updated local time didn't get plumbed back to main thread. Now that the plumbing is done, we should use NaN instead. Bug: 887659 Change-Id: I1ad3de622349b329addda98980b7aebbb7b33578 Reviewed-on: https://chromium-review.googlesource.com/c/1288710 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#600846} [modify] https://crrev.com/ce818d5024db8e242512d817f66b99b76096a4c9/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/ce818d5024db8e242512d817f66b99b76096a4c9/third_party/WebKit/LayoutTests/animations/animationworklet/worklet-animation-style-update.html [modify] https://crrev.com/ce818d5024db8e242512d817f66b99b76096a4c9/third_party/blink/renderer/modules/animationworklet/worklet_animation.cc
,
Oct 19
,
Oct 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c6a0fa49120d0d86b8e4eca9f1465e30031655e2 commit c6a0fa49120d0d86b8e4eca9f1465e30031655e2 Author: Yi Gu <yigu@chromium.org> Date: Fri Oct 19 21:04:34 2018 [animation worklet] Fix tests to not rely on the console log from worklet For worklet animations that run via the main thread, the console log from the worklet may not get back to the main thread within 2 frames. To fix this, we can either wait longer, i.e. wait an extra frame, or not rely on the console log from the worklet as what we do in this patch. Bug: 887659 Change-Id: Ifb8619f571f51a7f5abe132a2c65d7a58f59d600 Reviewed-on: https://chromium-review.googlesource.com/c/1289430 Reviewed-by: Majid Valipour <majidvp@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#601293} [modify] https://crrev.com/c6a0fa49120d0d86b8e4eca9f1465e30031655e2/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/c6a0fa49120d0d86b8e4eca9f1465e30031655e2/third_party/WebKit/LayoutTests/animations/animationworklet/animator-animate-expected.txt [modify] https://crrev.com/c6a0fa49120d0d86b8e4eca9f1465e30031655e2/third_party/WebKit/LayoutTests/animations/animationworklet/animator-animate.html [modify] https://crrev.com/c6a0fa49120d0d86b8e4eca9f1465e30031655e2/third_party/WebKit/LayoutTests/animations/animationworklet/animator-with-options-expected.txt [modify] https://crrev.com/c6a0fa49120d0d86b8e4eca9f1465e30031655e2/third_party/WebKit/LayoutTests/animations/animationworklet/animator-with-options.html
,
Oct 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b6960e4b1a32b97317e4696434bf86077868b630 commit b6960e4b1a32b97317e4696434bf86077868b630 Author: Yi Gu <yigu@chromium.org> Date: Thu Oct 25 22:24:10 2018 [animation worklet] Update unit test to work on main thread This patch is similar to crrev.com/c/1289430. Previously the test was relying on worklet console log which might be racy on main. Using computed style is better and more compatible. Bug: 887659 Change-Id: I8060546f654b08642e7554c66dbd017574e3c7a5 Reviewed-on: https://chromium-review.googlesource.com/c/1297182 Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#602898} [modify] https://crrev.com/b6960e4b1a32b97317e4696434bf86077868b630/third_party/WebKit/LayoutTests/TestExpectations [delete] https://crrev.com/ffcb158d35dc3f4ce5cb70b31353ba6fa9b62d46/third_party/WebKit/LayoutTests/animations/animationworklet/animation-worklet-inside-iframe-expected.txt [modify] https://crrev.com/b6960e4b1a32b97317e4696434bf86077868b630/third_party/WebKit/LayoutTests/animations/animationworklet/animation-worklet-inside-iframe.html [modify] https://crrev.com/b6960e4b1a32b97317e4696434bf86077868b630/third_party/WebKit/LayoutTests/animations/animationworklet/resources/animator-iframe.html
,
Oct 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/84af9252daaab1eef91d30dc7ca0c730d8c70b92 commit 84af9252daaab1eef91d30dc7ca0c730d8c70b92 Author: Yi Gu <yigu@chromium.org> Date: Fri Oct 26 14:50:20 2018 [animation worklet] Update unit tests to not rely on worklet console log This patch is similar to crrev.com/c/1289430. Previously the test was relying on worklet console log which might be racy on main. Using computed style is better and more compatible. Bug: 887659 Change-Id: I7fd64fcfb4a135d13e02574602111299d672139f Reviewed-on: https://chromium-review.googlesource.com/c/1301563 Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#603089} [modify] https://crrev.com/84af9252daaab1eef91d30dc7ca0c730d8c70b92/third_party/WebKit/LayoutTests/TestExpectations [delete] https://crrev.com/70e151d16404bbcd3c58d5b6a8006147f872361e/third_party/WebKit/LayoutTests/animations/animationworklet/worklet-animation-currentTime-expected.txt [modify] https://crrev.com/84af9252daaab1eef91d30dc7ca0c730d8c70b92/third_party/WebKit/LayoutTests/animations/animationworklet/worklet-animation-currentTime.html
,
Oct 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/14c838c7f94bbb65bcc7c3388c5b232c9b35e5a9 commit 14c838c7f94bbb65bcc7c3388c5b232c9b35e5a9 Author: Yi Gu <yigu@chromium.org> Date: Sat Oct 27 14:35:02 2018 Revert "[animation worklet] Update unit tests to not rely on worklet console log" This reverts commit 84af9252daaab1eef91d30dc7ca0c730d8c70b92. Reason for revert: Findit showed that it failed the fast path. Will take a look next week. Original change's description: > [animation worklet] Update unit tests to not rely on worklet console log > > This patch is similar to crrev.com/c/1289430. Previously the test was > relying on worklet console log which might be racy on main. Using > computed style is better and more compatible. > > Bug: 887659 > Change-Id: I7fd64fcfb4a135d13e02574602111299d672139f > Reviewed-on: https://chromium-review.googlesource.com/c/1301563 > Reviewed-by: Stephen McGruer <smcgruer@chromium.org> > Commit-Queue: Yi Gu <yigu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603089} TBR=yigu@chromium.org,smcgruer@chromium.org Change-Id: Idd103fdb515a2b9379cdcb2425ac68aa109bce13 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 887659 Reviewed-on: https://chromium-review.googlesource.com/c/1303799 Reviewed-by: Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#603336} [modify] https://crrev.com/14c838c7f94bbb65bcc7c3388c5b232c9b35e5a9/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/14c838c7f94bbb65bcc7c3388c5b232c9b35e5a9/third_party/WebKit/LayoutTests/animations/animationworklet/worklet-animation-currentTime-expected.txt [modify] https://crrev.com/14c838c7f94bbb65bcc7c3388c5b232c9b35e5a9/third_party/WebKit/LayoutTests/animations/animationworklet/worklet-animation-currentTime.html
,
Oct 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b92b7add2d36a845865691dd49e20f7ce7b9ba8c commit b92b7add2d36a845865691dd49e20f7ce7b9ba8c Author: Yi Gu <yigu@chromium.org> Date: Mon Oct 29 15:26:11 2018 [animation worklet] Fix flaky animation worklet layout test The origin patch crrev.com/c/1301563 was reverted due to flakiness on the fast path. The reason was animating accelerated properties on the compositor may require 2 frames. And getComputedStyle needs an extra frame after that to get the updated property value because it's done on main. Commit message from the origin patch: This patch is similar to crrev.com/c/1289430. Previously the test was relying on worklet console log which might be racy on main. Using computed style is better and more compatible. Bug: 887659 Change-Id: I1fb160274d4454fb6adafa4b295eebd505ad9a03 Reviewed-on: https://chromium-review.googlesource.com/c/1304693 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#603497} [modify] https://crrev.com/b92b7add2d36a845865691dd49e20f7ce7b9ba8c/third_party/WebKit/LayoutTests/TestExpectations [delete] https://crrev.com/706b8c94d35bb12afc3a0012831557c16d5cda58/third_party/WebKit/LayoutTests/animations/animationworklet/worklet-animation-currentTime-expected.txt [modify] https://crrev.com/b92b7add2d36a845865691dd49e20f7ce7b9ba8c/third_party/WebKit/LayoutTests/animations/animationworklet/worklet-animation-currentTime.html
,
Nov 6
Issue 849277 has been merged into this issue.
,
Nov 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fc5cd59f92f7f94996856d096d48ab1c1f0d572f commit fc5cd59f92f7f94996856d096d48ab1c1f0d572f Author: Yi Gu <yigu@chromium.org> Date: Tue Nov 13 15:42:48 2018 [animation worklet] Fix incorrect use of testharness in a Layouttest Currently there is a call to rAF inside step_func_done which means the test will actually complete before the rAF fires and so the assert_true will never run. Bug: 887659 Change-Id: Ic3d017cb106994507cba995ccf41133902c0d101 Reviewed-on: https://chromium-review.googlesource.com/c/1333887 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#607597} [modify] https://crrev.com/fc5cd59f92f7f94996856d096d48ab1c1f0d572f/third_party/WebKit/LayoutTests/animations/animationworklet/worklet-animation-currentTime.html
,
Jan 8
,
Jan 8
,
Jan 8
The remaining test animations/animationworklet/worklet-animation-currentTime.html is blocked by issue 785940.
,
Jan 9
Per #20, this issue is fixed. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by bugdroid1@chromium.org
, Sep 21