Report Previews via Intervention Report |
|||||||||
Issue descriptionThe reporting API (https://w3c.github.io/reporting/) provides a specific report format for interventions (https://w3c.github.io/reporting/#intervention-report). Previews should move to using that instead of the "Intervention" header. I believe ReportingObserver is close to shipping. (See: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/z4CWYor4UpQ/discussion)
,
Nov 5
The coding effort here is not too hard: A good candidate location is in frame_loader.cc CommitNavigation: https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/loader/frame_loader.cc?type=cs&g=0&l=997 I'm not a blink expert so it might be better to put one stack frame up in web_local_frame_impl.cc: https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/frame/web_local_frame_impl.cc?type=cs&g=0&l=2024 We should just need to call Intervention::GenerateReport(...) with a string ID (i.e., "LitePage") and a message (i.e., "Blocked attempt to load unneeded resources on a slow page load: <some chrome status entry>"). I think Ariel's input would be very valuable for determining the correct string, and I'd like to follow up with a one page design doc that we can send out to blink-dev. This should be completely doable in M73, but would be possible for M72 if needed.
,
Nov 29
,
Dec 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0c9f7932e5bca67ee04a48098e70b30f265b7db commit c0c9f7932e5bca67ee04a48098e70b30f265b7db Author: Ryan Sturm <ryansturm@chromium.org> Date: Thu Dec 06 01:13:49 2018 [previews] Reporting Lite Page interventions This CL adds Intevention Reporting API to inform origins that a preview (lite page mode) was used on a specific URL. This message is sent shortly after commit of a preview page. Bug: 887657 Change-Id: If94c75ecc9e56cf2335f20f1860b733c7594a41b Reviewed-on: https://chromium-review.googlesource.com/c/1356024 Reviewed-by: Nate Chapin <japhet@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#614214} [modify] https://crrev.com/c0c9f7932e5bca67ee04a48098e70b30f265b7db/chrome/browser/previews/previews_browsertest.cc [modify] https://crrev.com/c0c9f7932e5bca67ee04a48098e70b30f265b7db/third_party/blink/renderer/core/loader/document_loader.cc [modify] https://crrev.com/c0c9f7932e5bca67ee04a48098e70b30f265b7db/third_party/blink/renderer/core/loader/document_loader.h
,
Dec 6
,
Dec 7
We'd actually like to target M-72 for this, and the change is very straightforward.
,
Dec 7
Pls apply appropriate OSs label.
,
Dec 7
,
Dec 8
Your change meets the bar and is auto-approved for M72. Please go ahead and merge the CL to branch 3626 manually. Please contact milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 10
Pls merge you change to M72 branch 3626 ASAP so we can pick it up for next Dev/Beta release, RC cut on Monday, 12/10 @ 1:00 PM PT. Thank you.
,
Dec 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/756fd6748861517bee4e56fc70e62de03eb6d139 commit 756fd6748861517bee4e56fc70e62de03eb6d139 Author: Ryan Sturm <ryansturm@chromium.org> Date: Mon Dec 10 19:35:08 2018 [previews] Reporting Lite Page interventions This CL adds Intevention Reporting API to inform origins that a preview (lite page mode) was used on a specific URL. This message is sent shortly after commit of a preview page. Bug: 887657 Change-Id: If94c75ecc9e56cf2335f20f1860b733c7594a41b Reviewed-on: https://chromium-review.googlesource.com/c/1356024 Reviewed-by: Nate Chapin <japhet@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#614214}(cherry picked from commit c0c9f7932e5bca67ee04a48098e70b30f265b7db) Reviewed-on: https://chromium-review.googlesource.com/c/1370396 Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#227} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/756fd6748861517bee4e56fc70e62de03eb6d139/chrome/browser/previews/previews_browsertest.cc [modify] https://crrev.com/756fd6748861517bee4e56fc70e62de03eb6d139/third_party/blink/renderer/core/loader/document_loader.cc [modify] https://crrev.com/756fd6748861517bee4e56fc70e62de03eb6d139/third_party/blink/renderer/core/loader/document_loader.h
,
Dec 10
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/756fd6748861517bee4e56fc70e62de03eb6d139 Commit: 756fd6748861517bee4e56fc70e62de03eb6d139 Author: ryansturm@chromium.org Commiter: ryansturm@chromium.org Date: 2018-12-10 19:35:08 +0000 UTC [previews] Reporting Lite Page interventions This CL adds Intevention Reporting API to inform origins that a preview (lite page mode) was used on a specific URL. This message is sent shortly after commit of a preview page. Bug: 887657 Change-Id: If94c75ecc9e56cf2335f20f1860b733c7594a41b Reviewed-on: https://chromium-review.googlesource.com/c/1356024 Reviewed-by: Nate Chapin <japhet@chromium.org> Reviewed-by: Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#614214}(cherry picked from commit c0c9f7932e5bca67ee04a48098e70b30f265b7db) Reviewed-on: https://chromium-review.googlesource.com/c/1370396 Reviewed-by: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#227} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} |
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by sophiechang@chromium.org
, Nov 5