New issue
Advanced search Search tips

Issue 887651 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

apache license handling in platform2/

Project Member Reported by vapier@chromium.org, Sep 20

Issue description

the cros_license_check linter in platform2 is unhappy with the apache headers in projects we've moved back from Android:
  apmanager
  attestation
  shill
  tpm_manager
  trunks
  webserver

we can either migrate these back to BSD, or update the linter to allow these dirs to use Apache
 
+1 for migrating to BSD on shill. 
For apmanager - do we use it? Or was this migration done for Jetstream?


Cc: apronin@chromium.org
1) Is it ok to just re-license the sources from Apache to BSD? Not sure if it causes issues if we first release the sources under one license and then change it.

2) If we keep the licenses and change the presubmitchecks instead, here's what I had in mind:

-[capturing from a separate email thread]-

It doesn't make sense to just disable header checks for those packages, so initially I was going to update platform2/PRESUBMIT.cfg to do something like

========
[Hook Overrides]
aosp_license_check: true

[Hook Overrides Options]
cros_license_check: --exclude_regex=^(trunks|attestation|tpm_manager)/.*
aosp_license_check: --exclude_regex=^(?!(trunks|attestation|tpm_manager)).*
========

However, since these packages were moved to platform2, there were new files created inside (e.g. trunks/pinweaver*), and those new files have CrOS license headers. Managing license checking on a per-file basis doesn't feel right. 

So, I was wondering if it instead makes sense to add a new _check_aosp_or_cros_license option to src/repohooks/pre-upload.py that'd be happy if either one of headers is present. And use aosp_or_cros_license_check in place of aosp_license_check in the PRESUBMIT.cfg change from above.

WDYT re (2)?

Sign in to add a comment