New issue
Advanced search Search tips

Issue 887647 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 26
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug
Team-Accessibility



Sign in to add a comment

Missing whitespace in accessible name from label with text input child

Project Member Reported by joanmari...@gmail.com, Sep 20

Issue description

Steps to reproduce:
1. Load the attached test case.
2. Use the platform's accessibility inspector to obtain the name of the input with id of "test".

Expected results: The name would be "foo bar baz"

Actual results: The name is "foobarbaz"

 
missing-whitespace.html
132 bytes View Download
Owner: joanmari...@gmail.com
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/66a81dbc8f757a25c47856ae83afff7b0b03fa87

commit 66a81dbc8f757a25c47856ae83afff7b0b03fa87
Author: Joanmarie Diggs <jdiggs@igalia.com>
Date: Wed Sep 26 10:53:19 2018

Separate controls within labels from text in accessible name calculation

AXNodeObject::TextFromDescendants() inserts a space to separate two
layout objects when they are not in the same inline block flow. The
same needs to be done for inline controls according to the Accessible
Name and Description Computation spec. Making this change also causes
us to return the same name as Gecko and WebKit.

Bug:  887647 
Change-Id: Ie868ffaf0b7217615d4a68d589863f1d50dfbe4c
Reviewed-on: https://chromium-review.googlesource.com/1240516
Commit-Queue: Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594273}
[modify] https://crrev.com/66a81dbc8f757a25c47856ae83afff7b0b03fa87/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_test.extjs
[modify] https://crrev.com/66a81dbc8f757a25c47856ae83afff7b0b03fa87/content/browser/accessibility/dump_accessibility_tree_browsertest.cc
[modify] https://crrev.com/66a81dbc8f757a25c47856ae83afff7b0b03fa87/content/test/data/accessibility/aria/aria-level-expected-blink.txt
[modify] https://crrev.com/66a81dbc8f757a25c47856ae83afff7b0b03fa87/content/test/data/accessibility/aria/aria-level-expected-mac.txt
[modify] https://crrev.com/66a81dbc8f757a25c47856ae83afff7b0b03fa87/content/test/data/accessibility/aria/aria-level-expected-win.txt
[modify] https://crrev.com/66a81dbc8f757a25c47856ae83afff7b0b03fa87/content/test/data/accessibility/aria/aria-tree-expected-android.txt
[modify] https://crrev.com/66a81dbc8f757a25c47856ae83afff7b0b03fa87/content/test/data/accessibility/aria/aria-tree-expected-blink.txt
[modify] https://crrev.com/66a81dbc8f757a25c47856ae83afff7b0b03fa87/content/test/data/accessibility/aria/aria-tree-expected-mac.txt
[modify] https://crrev.com/66a81dbc8f757a25c47856ae83afff7b0b03fa87/content/test/data/accessibility/aria/aria-tree-expected-win.txt
[modify] https://crrev.com/66a81dbc8f757a25c47856ae83afff7b0b03fa87/content/test/data/accessibility/html/button-content-changed-expected-blink.txt
[add] https://crrev.com/66a81dbc8f757a25c47856ae83afff7b0b03fa87/content/test/data/accessibility/html/input-inside-label-expected-blink.txt
[add] https://crrev.com/66a81dbc8f757a25c47856ae83afff7b0b03fa87/content/test/data/accessibility/html/input-inside-label.html
[modify] https://crrev.com/66a81dbc8f757a25c47856ae83afff7b0b03fa87/third_party/WebKit/LayoutTests/accessibility/aria-owns-ignores-leafs.html
[modify] https://crrev.com/66a81dbc8f757a25c47856ae83afff7b0b03fa87/third_party/blink/renderer/modules/accessibility/ax_node_object.cc

Status: Fixed (was: Started)

Sign in to add a comment