Tab close X hovered state has insufficient contrast in some themes |
|||
Issue descriptionForked from bug https://bugs.chromium.org/p/chromium/issues/detail?id=883257 . For a test case use the theme there: https://chrome.google.com/webstore/detail/chuck-anderson/gegkoiakifeoejnjkbnnojkkdoegeofp We should modify the code that computes the hover circle around the close X from being computed against the unhovered background color to being computed against the hovered background color. This will have little effect in the common case of the two being similar, but for edge cases like this theme, it will make a big difference. Note that we will then _also_ probably have to compute the hovered close X color against the hover circle, not against either the hovered or unhovered tab background. So there's a sequence of computations.
,
Sep 24
@1: Since this isn't currently assigned to anyone, no one else is actively working on it, so a good thing to do would be to create a patch and submit it for initial review using the process on https://www.chromium.org/developers/contributing-code . This bug can't currently be assigned directly to you, but that doesn't block you contributing in this fashion.
,
Sep 28
I think describe possible core of problem: generation of color for circle X is calculated by ACTIVE and INACTIVE color tabs only. But the final color of tabs is dependent of custom image in the theme IDR_THEME_TOOLBAR and some rule for hover effect. And now color for circle X does not include custom image in the theme IDR_THEME_TOOLBAR and some special rule for hover effect. I propose solution find real color of tab at the step of generation of color for circle X. And then make right color for circle.
,
Sep 28
The image's color is accounted for during the theme parsing process; the only issue is the lack of accounting for hover.
,
Dec 28
,
Jan 4
|
|||
►
Sign in to add a comment |
|||
Comment 1 by vt.ostap...@gmail.com
, Sep 24