New issue
Advanced search Search tips

Issue 887639 link

Starred by 1 user
Status: Verified
Owner:
rtoy@chromium.org
Closed: Sep 21
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Compilation failure when DEBUG_AUDIONODE_REFERENCES is enabled

Project Member Reported by rtoy@chromium.org, Sep 20 
If you set DEBUG_AUDIONODE_REFERENCES (in audio_node.h) to a non-zero value, chrome fails to build with the error:

./../third_party/blink/renderer/modules/webaudio/audio_node.cc:421:11: error: format specifies type 'size_t' (aka 'unsigned long') but the argument has type 'WTF::wtf_size_t' (aka 'unsigned int') [-Werror,-Wformat]
          outputs_.size());
          ^~~~~~~~~~~~~~~

Fix this.
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/370155951ae20fd26c8e36198500ed4522b495a1

commit 370155951ae20fd26c8e36198500ed4522b495a1
Author: Raymond Toy <rtoy@chromium.org>
Date: Thu Sep 20 23:56:02 2018

Fix compile error when DEBUG_AUDIONODE_REFERENCES is on

The return type of size() was recently changed from size_t to
unsigned.  Adjust printf string for that.

Bug:  887639 
Test: Doesn't affect any test
Change-Id: I371ee874bc4e3af6fd9891f059ce6423fdd498a8
Reviewed-on: https://chromium-review.googlesource.com/1236269
Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593006}
[modify] https://crrev.com/370155951ae20fd26c8e36198500ed4522b495a1/third_party/blink/renderer/modules/webaudio/audio_node.cc

Comment 2 by rtoy@chromium.org, Sep 21

Status: Verified (was: Started)
►

Sign in to add a comment