Issue metadata
Sign in to add a comment
|
Only one entry is shown in the exception list for each site setting |
||||||||||||||||||||||||
Issue descriptionChrome Version: 71.0.3556 (Official Build) canary (32-bit) OS: Android 9; Pixel XL Build/PP2.181005.003 What steps will reproduce the problem? (1) Disable javascript in content settings (2) Add a number of site exceptions (3) VIsit the setting page -> settings -> Site Settings -> Javascript What is the expected result? All sites I've added as exceptions are shown What happens instead? Only one is shown, but I know there are others because I can visit them (e.g. nytimes.com) and javascript runs. This seems like a regression, because previously when I visited this page, all the sites would show, now just one does. Please use labels and text to provide additional information. If this is a regression (i.e., worked before), please consider using the bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help us identify the root cause and more rapidly triage the issue. For graphics-related bugs, please copy/paste the contents of the about:gpu page at the end of this report.
,
Sep 21
,
Sep 21
Assiging to the new permissions team to triage...
,
Sep 21
As per comment#3 changing status to Assigned, please feel free to remove if not applicable. Thanks!
,
Sep 24
I could reproduce this with 71.0.3557.2 (Canary), but still works fine with 70.0.3538.27 (Beta). Desktop is also not affected, so I suppose it's an Android UI regression? @Kamila, could you please look into this? Not sure if there is a better way to bisect than manually doing a binary search by installing builds from go/qhewr (using adb).
,
Sep 24
This seems to be affecting all content settings exception lists.
,
Sep 24
,
Sep 25
I reverted all my CLs (see issue 854737) locally and the problem still repros, so I don't think it's related to my recent work.
,
Sep 27
still happening on 71.0.3562.0. don't we have a way of bisecting on android? maybe I can try adding the magic label.
,
Oct 1
,
Oct 5
,
Oct 5
I did a manual bisect, and the regression occurred in this range: https://chromium.googlesource.com/chromium/src/+log/71.0.3542.0..71.0.3543.0?pretty=fuller&n=10000 @Marcin, your CL (crrev.com/c/1195373) is my best guess, can you please take a look?
,
Oct 5
I will check it in next few hours.
,
Oct 6
Fix is waiting for review: https://chromium-review.googlesource.com/c/chromium/src/+/1266395 Thx for good bisect and thx for submitting bug info, please take apologies for previous buggy CL.
,
Oct 8
,
Oct 8
Marking this as `started` while the fix is under review.
,
Oct 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad41381929338e7b2dc078d9b6fcd3b68d9a5aa6 commit ad41381929338e7b2dc078d9b6fcd3b68d9a5aa6 Author: Marcin Wiacek <marcin@mwiacek.com> Date: Mon Oct 08 18:35:11 2018 Fix cutting off list of sites in Settings->SiteSettings->(category) Bug was added with https://chromium-review.googlesource.com/c/chromium/src/+/1195373. Currently: there is displayed maximally one site on exception list in every Settings->SiteSettings->(category) screen. It happens because of return which is ending not only internal for, but also external one. With fix: there are displayed all sites. BUG= 887595 Change-Id: I924f7a6955134f9a18976c6dbab201e8b404432c Reviewed-on: https://chromium-review.googlesource.com/c/1266395 Reviewed-by: Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#597622} [modify] https://crrev.com/ad41381929338e7b2dc078d9b6fcd3b68d9a5aa6/chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePermissionsFetcher.java
,
Oct 8
,
Oct 9
Works as per expected behavior, Verified on 71.0.3574.0 |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by wfh@chromium.org
, Sep 2072.2 KB
72.2 KB View Download