Issue metadata
Sign in to add a comment
|
SocketPosix::IsConnected[AndIdle] behavior is different on Fuchsia. |
||||||||||||||||||||
Issue descriptionSocketPosix::IsConnected() and SockedPosix::IsConnectedAndIdle() has a difference in behavior that caused the TCPSocketTest.BeforeConnectCallback net test to fail. The non-Fuchsia implementation uses MSG_PEEK, which is not implemented on Fuchsia.
,
Jan 11
,
Jan 11
Note that this is tracked in Fuchsia by bug NET-121.
,
Jan 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/372b03421362c7e14298e471451fd76223d0780d commit 372b03421362c7e14298e471451fd76223d0780d Author: Wez <wez@chromium.org> Date: Sat Jan 12 00:09:47 2019 [Fuchsia] Fix SocketPosix::IsConnected() pre-Connect() behaviour. SocketPosix::IsConnected() has a Fuchsia-specific implementation, to work-around the lack of a working recvmsg(MSG_PEEK). This was incorrectly returning |true| when a SocketPosix was not-yet-connected. Fix the Fuchsia implementation to report |false| in this case, and re-enable a TCPClientSocket test that depends on it. Add a TCPClientSocket test for the behaviour of both the IsConnected() and IsConnectedAndIdle() APIs. Bug: 887587 Change-Id: I5b7ef9fa7f98364ee5612cf8d472a13ebbeab164 Reviewed-on: https://chromium-review.googlesource.com/c/1407505 Commit-Queue: Wez <wez@chromium.org> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#622231} [modify] https://crrev.com/372b03421362c7e14298e471451fd76223d0780d/net/socket/socket_posix.cc [modify] https://crrev.com/372b03421362c7e14298e471451fd76223d0780d/net/socket/tcp_socket_unittest.cc [modify] https://crrev.com/372b03421362c7e14298e471451fd76223d0780d/testing/buildbot/filters/fuchsia.net_unittests.filter
,
Jan 12
These APIs now work as expected, using a Fuchsia-specific implementation. Marking ExternalDependency for us to follow-up when MSG_PEEK is available.
,
Jan 19
(4 days ago)
,
Jan 19
(4 days ago)
ZX-769 tracks support for peek operations on Zircon sockets, which is required by MSG_PEEK. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Sep 20