Issue metadata
Sign in to add a comment
|
SessionRestoreTest.MemoryPressureLoadsNotAllTabs is flaky on Linux Chromium OS ASan LSan |
||||||||||||||||||||
Issue descriptionFlakiness was reported by FindIt - see https://chromium-review.googlesource.com/c/chromium/src/+/1194879#message-e8e41e47f96e8e050308a264b51b2d621affacf5
,
Sep 20
<adding people from issue 860090 where the same test was marked as flaky [but is fixed/passing now / before r590331?]>
,
Sep 20
,
Sep 20
Hmmm... actually I speculate that something in the system tries to dereference base::MemoryPressureMonitor::Get() [which will be null after r590331]. The fix for this is to use base::test::FakeMemoryPressureMonitor from the test (instead of having the test directly dispatch a memory pressure notification). Maybe we can try this speculative fix first, before disabling the test. WIP CL @ https://crrev.com/c/1236502
,
Sep 20
Flakiness dashboard for this particular test: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=SessionRestoreTest.MemoryPressureLoadsNotAllTabs
,
Sep 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/481767eb9c2c2034f8cd53f9a699a0f6545c22f0 commit 481767eb9c2c2034f8cd53f9a699a0f6545c22f0 Author: Lukasz Anforowicz <lukasza@chromium.org> Date: Thu Sep 20 19:51:45 2018 Speculative fix for flakiness of MemoryPressureLoadsNotAllTabs. The test flakily crashes with an unknown callstack (the crash is not reproducible locally). The speculation is that the crash is related to dereferencing a null base::MemoryPressureMonitor::Get(). If this is indeed the case, then the crash should be fixed by using base::test::FakeMemoryPressureMonitor in the test (rather than directly dispatching a memory pressure notification from the test). Bug: 887545 Change-Id: Ib922ebe4c7f85ec028f4bb202f2357c71e20687a Reviewed-on: https://chromium-review.googlesource.com/1236502 Reviewed-by: Chris Hamilton <chrisha@chromium.org> Commit-Queue: Ćukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#592913} [modify] https://crrev.com/481767eb9c2c2034f8cd53f9a699a0f6545c22f0/chrome/browser/sessions/session_restore_browsertest.cc
,
Sep 20
Let's check next week if the flakiness is gone.
,
Sep 24
The NextAction date has arrived: 2018-09-24
,
Sep 24
The flakiness dashboard link from #c5 is all green - let's mark this as fixed. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by lukasza@chromium.org
, Sep 20