New issue
Advanced search Search tips

Issue 887540 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Error printed to terminal when using depot_tools offline

Project Member Reported by sdy@chromium.org, Sep 20

Issue description

If I use any depot_tools function (help, git cl format) while offline, after the command exits the following is printed to my terminal:

    urllib2.URLError: <urlopen error [Errno 8] nodename nor servname provided, or not known>
 
It's printed along with a big stack trace, I meant to say!

CL:
https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1236893
Project Member

Comment 2 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/e373f26c5c3b7327046ef1af22176456a19147c6

commit e373f26c5c3b7327046ef1af22176456a19147c6
Author: Sidney San Martín <sdy@chromium.org>
Date: Thu Sep 20 17:51:29 2018

Suppress URLErrors when uploading metrics.

These can just be from not having a network connection.

Bug:  887540 
Change-Id: Ie025cc278a4633d688bfb34544ecaaacb2df1bad
Reviewed-on: https://chromium-review.googlesource.com/1236893
Auto-Submit: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/e373f26c5c3b7327046ef1af22176456a19147c6/upload_metrics.py

Cc: ehmaldonado@chromium.org
Owner: sdy@chromium.org
Status: Fixed (was: Untriaged)
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2da56e8e8205bb242b385bc725dfefaf4e57e8a6

commit 2da56e8e8205bb242b385bc725dfefaf4e57e8a6
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Thu Sep 20 20:06:37 2018

Roll src/third_party/depot_tools a5ac303c5308..9cba9ffdfdc6 (2 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a5ac303c5308..9cba9ffdfdc6


git log a5ac303c5308..9cba9ffdfdc6 --date=short --no-merges --format='%ad %ae %s'
2018-09-20 dpranke@chromium.org Add the crcmod wheel for gsutil, to get it to shut up.
2018-09-20 sdy@chromium.org Suppress URLErrors when uploading metrics.


Created with:
  gclient setdep -r src/third_party/depot_tools@9cba9ffdfdc6

The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:875100, chromium:887540 
TBR=agable@chromium.org

Change-Id: I9e8794867feb346151dffeb261dc9f16089db3c5
Reviewed-on: https://chromium-review.googlesource.com/1236880
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#592920}
[modify] https://crrev.com/2da56e8e8205bb242b385bc725dfefaf4e57e8a6/DEPS

Sign in to add a comment