New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 887536 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

The Chrome OS CQ has no bvt-cq coverage

Project Member Reported by bhthompson@google.com, Sep 20

Issue description

It was recently discovered in  https://crbug.com/887500#c3  that our CQ coverage for the bvt-cq suite has been broken since https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1146146 landed, which replaced bvt-cq entirely with bvt-tast-cq, which does not have the same test coverage, thus CLs can make it through the CQ, and break release and PFQ builders which do run bvt-cq. 

An example of the problem can be seen in https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1236534 where the config_dump.json shows what the change actually does, replacing bvt-cq with bvt-tast-cq instead of adding an additional test configuration for bvt-tast-cq.
 
Status: Started (was: Untriaged)
There's more discussion at https://crrev.com/c/1236534. It sounds like it'll be fixed soon.

I'll start a postmortem doc, as this seems really bad.
Description: Show this description
Owner: dgarr...@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/713f53360e2efa114ad709864cf641118e273742

commit 713f53360e2efa114ad709864cf641118e273742
Author: Don Garrett <dgarrett@google.com>
Date: Thu Sep 20 18:01:31 2018

chromeos_config: Allow multiple sharded tests on one board.

When assigning sharded hwtests to boards in the CQ, our config called
for multiple suites to be assigned to the same board, but the logic
only supported assigning a single sharded suite to a given board.

Support multiple suites per board.

BUG= chromium:887536 
TEST=run_tests + config_dump.json diff.

Change-Id: Id2198cafe83629eb8599944308977f35f2fc4ebe
Reviewed-on: https://chromium-review.googlesource.com/1236538
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Bernie Thompson <bhthompson@chromium.org>

[modify] https://crrev.com/713f53360e2efa114ad709864cf641118e273742/config/chromeos_config.py
[modify] https://crrev.com/713f53360e2efa114ad709864cf641118e273742/config/config_dump.json

Status: Fixed (was: Started)
Hopefully, fixed.

Sign in to add a comment