New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 887499 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Sep 20
Cc:
skare@chromium.org
isherman@chromium.org
asvitk...@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

histogram_suffix notation should support base="true" for multi-level suffix

Project Member Reported by rkaplow@chromium.org, Sep 20 
You can do a multi level suffix, i.e.

A.B1.C1, A.B1.C2, A.B2.C2, A.B2.C2

with A having base="true" then A won't get autocompleted in UMA tools.

However A.B1 and A.B2 will get automcompleted which is confusing.

We should modify oru suffix logic to make this not occur, perhaps having a base=true existing somewhere in the suffix itself.

Comment 1 by vabr@chromium.org, Sep 20 

And once we have a way to do this, the two histograms mentioned in https://crrev.com/c/1235720 are good candidates to be fixed (or verified if the fixing works automatically).

Comment 2 by isherman@chromium.org, Sep 20

Status: Fixed (was: Available)
I'm pretty sure that base=true is already possible for histogram suffixes. See the TaskSchedulerName suffixes, for example.

Comment 3 by rkaplow@chromium.org, Sep 20 

Thanks, I did not know that! It actually is explained in the docs here:

https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/histograms/README.md#histogram-suffixes

vabr@ so you can make that change then

Comment 4 by vabr@chromium.org, Sep 25 

Thanks to both of you!

I made the suggested change and sent it to Ilya for review.
►

Sign in to add a comment