New issue
Advanced search Search tips

Issue 887468 link

Starred by 1 user
Status: Verified
Owner:
hanxi@chromium.org
Closed: Nov 2
Cc:
paulmiller@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug

Blocking:
issue 729596
issue 899376



Sign in to add a comment

Move FeatureListCreation on WebView from AwBrowserMainParts::PreCreateThreads() to AwMainDelegate::PostEarlyInitialization().

Project Member Reported by hanxi@chromium.org, Sep 20 
The FeatureList should be created before starting the TaskSchedueler in ContentMainRunnerImpl. This is because TaskSchedueler needs to check a flag and requires the FeatureList is ready.

Currently, the FeatureList creation on Cast is implemented in AwBrowserMainParts::PreCreateThreads(), so we should move it to AwMainDelegate::PostEarlyInitialization() which happens before TaskSchedueler starts.

Comment 1 by paulmiller@chromium.org, Sep 20

Components: Mobile>WebView
Labels: OS-Android

Comment 2 by hanxi@chromium.org, Oct 29

Blocking: 899376
Labels: -Pri-3 Pri-2
Owner: hanxi@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9fbe388f4983f515c05b314059bfce213532a3a

commit a9fbe388f4983f515c05b314059bfce213532a3a
Author: Xi Han <hanxi@google.com>
Date: Thu Nov 01 19:17:45 2018

Create FeatureList and setup field trials early in WebView.

In this CL, we move the creates FeatureList and setup field trials from
AwBrowserMainParts::PreCreateThreads() to
AwMainDelegate::PostEarlyInitialization(). So it happens before
ServiceManagerContext is created and the TaskSchedueler starts in
ContentMainRunnerImpl::Run().

Bug:  887468 , 899376 
Change-Id: Ie4d3223cf5206d8aadb537b7b80d9e196d4512be
Reviewed-on: https://chromium-review.googlesource.com/c/1305876
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Paul Miller <paulmiller@chromium.org>
Commit-Queue: Xi Han <hanxi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604661}
[modify] https://crrev.com/a9fbe388f4983f515c05b314059bfce213532a3a/android_webview/BUILD.gn
[modify] https://crrev.com/a9fbe388f4983f515c05b314059bfce213532a3a/android_webview/browser/aw_browser_main_parts.cc
[modify] https://crrev.com/a9fbe388f4983f515c05b314059bfce213532a3a/android_webview/browser/aw_browser_main_parts.h
[modify] https://crrev.com/a9fbe388f4983f515c05b314059bfce213532a3a/android_webview/browser/aw_content_browser_client.cc
[modify] https://crrev.com/a9fbe388f4983f515c05b314059bfce213532a3a/android_webview/browser/aw_content_browser_client.h
[modify] https://crrev.com/a9fbe388f4983f515c05b314059bfce213532a3a/android_webview/browser/aw_content_browser_client_unittest.cc
[add] https://crrev.com/a9fbe388f4983f515c05b314059bfce213532a3a/android_webview/browser/aw_feature_list_creator.cc
[add] https://crrev.com/a9fbe388f4983f515c05b314059bfce213532a3a/android_webview/browser/aw_feature_list_creator.h
[delete] https://crrev.com/dec7e58f53d48081c9ffb5ea586def3ad05de702/android_webview/browser/aw_field_trial_creator.cc
[delete] https://crrev.com/dec7e58f53d48081c9ffb5ea586def3ad05de702/android_webview/browser/aw_field_trial_creator.h
[modify] https://crrev.com/a9fbe388f4983f515c05b314059bfce213532a3a/android_webview/browser/aw_metrics_service_client.cc
[modify] https://crrev.com/a9fbe388f4983f515c05b314059bfce213532a3a/android_webview/browser/aw_metrics_service_client.h
[modify] https://crrev.com/a9fbe388f4983f515c05b314059bfce213532a3a/android_webview/glue/java/src/com/android/webview/chromium/WebViewChromiumAwInit.java
[modify] https://crrev.com/a9fbe388f4983f515c05b314059bfce213532a3a/android_webview/java/src/org/chromium/android_webview/VariationsSeedLoader.java
[modify] https://crrev.com/a9fbe388f4983f515c05b314059bfce213532a3a/android_webview/lib/aw_main_delegate.cc
[modify] https://crrev.com/a9fbe388f4983f515c05b314059bfce213532a3a/android_webview/lib/aw_main_delegate.h

Comment 4 by hanxi@chromium.org, Nov 2

Status: Fixed (was: Started)

Comment 5 by sbashyam@google.com, Nov 6 

Please add QA manual verification steps if verifiable.Thanks

Comment 6 by paulmiller@chromium.org, Nov 29

Status: Verified (was: Fixed)
I don't think this can be manually verified. There should be no user-visible changes.
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 29 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/30f71753b38f361607fafbf8f1788b4afee58fa9

commit 30f71753b38f361607fafbf8f1788b4afee58fa9
Author: Paul Miller <paulmiller@google.com>
Date: Thu Nov 29 21:56:06 2018

WebView: Fix "Feture" typo

$ sed -i s/Feture/Feature/ android_webview/{browser/aw_feature_list_creator.*,lib/aw_main_delegate.cc}

BUG= 887468 

Change-Id: I531c027f857f35d1dda91684dc2a5b56403dc1e2
Reviewed-on: https://chromium-review.googlesource.com/c/1355940
Reviewed-by: Tao Bai <michaelbai@chromium.org>
Commit-Queue: Paul Miller <paulmiller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612391}
[modify] https://crrev.com/30f71753b38f361607fafbf8f1788b4afee58fa9/android_webview/browser/aw_feature_list_creator.cc
[modify] https://crrev.com/30f71753b38f361607fafbf8f1788b4afee58fa9/android_webview/browser/aw_feature_list_creator.h
[modify] https://crrev.com/30f71753b38f361607fafbf8f1788b4afee58fa9/android_webview/lib/aw_main_delegate.cc
►

Sign in to add a comment