New issue
Advanced search Search tips

Issue 887467 link

Starred by 1 user
Status: WontFix
Owner:
erikc...@chromium.org
Closed: Sep 20
Cc:
ellyjo...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

MacViews: Adding shortcuts to bookmarks via System Preferences doesn't work

Project Member Reported by lgrey@chromium.org, Sep 20 
Via this public report:
https://www.reddit.com/r/chrome/comments/9gy8bb/recent_chrome_update_prevents_mac_keyboard/

This is a regression from Cocoa.

Chrome Version: 71.0.3555.0
OS: MacOS

What steps will reproduce the problem?
(1) Add a top-level bookmark with an easily typable name, so that it shows up in the Bookmarks menu (see first attached screenshot).
(2) Add a shortcut to Chrome in System Preferences > Keyboard > Shortcuts with the bookmarks' name (see second attached screenshot).
(3) Verify that the shortcut is displayed in the menu (see third attached screenshot).
(4) Type the shortcut.

What is the expected result?
Chrome navigates to the bookmark

What happens instead?
The default shortcut is triggered.
Screen Shot 2018-09-20 at 10.42.29 AM.png
24.9 KB View Download
Screen Shot 2018-09-20 at 10.42.08 AM.png
97.2 KB View Download
Screen Shot 2018-09-20 at 10.42.01 AM.png
24.3 KB View Download

Comment 1 by ellyjo...@chromium.org, Sep 20

Labels: -Pri-3 Target-72 M-72 Pri-2
Owner: erikc...@chromium.org
Status: Assigned (was: Untriaged)
erikchen@ recently rewrote all of this - erik, can you take a peek? :)

Comment 2 by erikc...@chromium.org, Sep 20

Status: WontFix (was: Assigned)
The shortcut "cmd 1" is reserved by Chrome to navigate to the first tab in the window. I tried another shortcut -- e.g. cmd + shift + U and it worked fine.

Comment 3 by lgrey@chromium.org, Sep 20 

Sure, but it's still a regression, no?

Comment 4 by lgrey@chromium.org, Sep 20 

For example, I can rename Command+N in Finder to "Zoom"

Comment 5 by erikc...@chromium.org, Sep 20 

This is an intended behavior change. This causes Chrome to match the behavior of Safari -- where special hotkeys that don't show up in the menu like "cmd 1" [to switch to the first tab] cannot be overridden. I just tried this -- Safari has the same behavior as Chrome.

The root problem is that we cannot simultaneously satisfy all desired ordering constraints.

In general, we want 
1) Chrome special hotkeys to have greater priority than Web Contents.
2) Web Contents to have greater priority than macOS Menu shortcuts
3) some macOS Menu shortcuts to have higher priority than Chrome special hotkeys [this case]. 

This is an over simplification of the set of constraints we need to simultaneously satisfy. Every consumer of hotkeys wants to be the "highest priority" consumer. We can't make this happen everywhere.
►

Sign in to add a comment