New issue
Advanced search Search tips

Issue 887465 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 4
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883330



Sign in to add a comment

Convert SigninObserverBridge to IdentityManager::Observer

Project Member Reported by sdefresne@chromium.org, Sep 20

Issue description

Implements
- GoogleSigninSucceeded
- GoogleSignedOut

 
Owner: ----
Status: Available (was: Assigned)
Owner: ma...@igalia.com
Status: Started (was: Available)
CL in progress here:
https://chromium-review.googlesource.com/c/chromium/src/+/1257834
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a70958a47152e3fcf66fb3854e9d2fd39a569c98

commit a70958a47152e3fcf66fb3854e9d2fd39a569c98
Author: Mario Sanchez Prada <mario@igalia.com>
Date: Thu Oct 04 13:54:39 2018

Convert SigninObserverBridge to IdentityManager::Observer

Migrated to IdentityManager::Observer and implemented the corresponding
virtual functions from there.

Bug:  887465 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I9436fe11d90b7593d05a0bf97ab11134d12105b7
Reviewed-on: https://chromium-review.googlesource.com/c/1257834
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596651}
[modify] https://crrev.com/a70958a47152e3fcf66fb3854e9d2fd39a569c98/ios/chrome/browser/ui/settings/BUILD.gn
[modify] https://crrev.com/a70958a47152e3fcf66fb3854e9d2fd39a569c98/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm

Status: Fixed (was: Started)

Sign in to add a comment