New issue
Advanced search Search tips

Issue 887461 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 26
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 889863

Blocking:
issue 883330



Sign in to add a comment

Convert PeopleHandler to IdentityManager::Observer

Project Member Reported by sdefresne@chromium.org, Sep 20

Issue description

Implements
- GoogleSigninSucceeded
- GoogleSignedOut

 
Owner: ----
Status: Available (was: Assigned)
Blocking: 890796
Owner: ma...@igalia.com
Status: Started (was: Available)
I need this one before I can provide a CL for 890796, assigning.
Blockedon: 890794 889863
There still a few things that need to be in place before this can be fixed, but I put a WIP CL in https://chromium-review.googlesource.com/c/chromium/src/+/1261637 in the meantime.
Blockedon: 890796
Blocking: -890796
> I need this one before I can provide a CL for 890796, assigning.

Actually, it's the other way around I just noticed: once 889863 and 890794 are fixed, this can be ported with the exception of the call to GetStatusLabels(), that will need to receive a SigninManager until 890796 gets fixed.

Updating WIP CL and deps...
Blockedon: -890794 -890796
I've split the bits unrelated to IdentityManager::Observer to  crbug.com/898810 , so this is no longer blocked on issues  890794  and  890796 .
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/35af51e397a46b2adb8a27a305e58b97559208a2

commit 35af51e397a46b2adb8a27a305e58b97559208a2
Author: Mario Sanchez Prada <mario@igalia.com>
Date: Fri Oct 26 09:51:38 2018

Convert PeopleHandler to IdentityManager::Observer

Reimplement callbacks GoogleSigninSucceeded and GoogleSignedOut as
OnPrimaryAccountSet and OnPrimaryAccountCleared, from IdentityManager.

Bug:  887461 
Change-Id: I6a0f5758b8c07f21a8b06b4993a9f58528ee7c7e
Reviewed-on: https://chromium-review.googlesource.com/c/1261637
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603044}
[modify] https://crrev.com/35af51e397a46b2adb8a27a305e58b97559208a2/chrome/browser/ui/webui/settings/people_handler.cc
[modify] https://crrev.com/35af51e397a46b2adb8a27a305e58b97559208a2/chrome/browser/ui/webui/settings/people_handler.h

Status: Fixed (was: Started)

Sign in to add a comment