New issue
Advanced search Search tips

Issue 887456 link

Starred by 1 user
Status: Assigned
Owner:
mustaq@chromium.org
Cc:
clamy@chromium.org
csharrison@chromium.org
dgozman@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Investigate recreating gesture tokens after navigation commit

Project Member Reported by mustaq@chromium.org, Sep 20 
I think we have two calls that recreate user gesture tokens following a navigation:
- In RenderFrameImpl::CommitNavigation:
https://cs.chromium.org/chromium/src/content/renderer/render_frame_impl.cc?rcl=687f17cae1a4d97b29cecf9718ada5bee749e470&l=3103
- In RenderFrameImpl::CommitSameDocumentNavigation:
https://cs.chromium.org/chromium/src/content/renderer/render_frame_impl.cc?rcl=687f17cae1a4d97b29cecf9718ada5bee749e470&l=3368

Not sure why these are needed because I thought "commit" means new tab/window has been created already if needed.

We should investigate.

Comment 1 by csharrison@chromium.org, Sep 20

Cc: clamy@chromium.org
A navigation "commit" can happen in the same tab. In the "same document" case we don't even switch to a new document (e.g. history push state).

I'm not sure why this is needed though, it is only scoped to that one method right?

Comment 2 by mustaq@chromium.org, Sep 20 

Yes, the scoping is tight, and I would like to know what part of navigation within that scope relies on activation.
►

Sign in to add a comment