New issue
Advanced search Search tips

Issue 887453 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 883330



Sign in to add a comment

Convert RendererUpdater to IdentityManager::Observer

Project Member Reported by sdefresne@chromium.org, Sep 20

Issue description

Implements
- GoogleSigninSucceeded
- GoogleSignedOut

 
Owner: ----
Status: Available (was: Assigned)
Status: Assigned (was: Available)
Taking this then...
Owner: svil...@igalia.com
Status: Started (was: Assigned)
Blocking: 894075
Cc: blundell@chromium.org
 Issue 903877  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1bdcf632f3345eae5f589a5280fb85b4d4f210b1

commit 1bdcf632f3345eae5f589a5280fb85b4d4f210b1
Author: Sergio Villar Senin <svillar@igalia.com>
Date: Tue Nov 13 10:59:51 2018

Migrate RendererUpdater to IdentityManager

It's currently observer SigninManager but it could instead observe
IdentityManager. This will allow RenderUpdater to eventually use the
identity service.

Bug:  887453 
Change-Id: I588bcdaa1e0c5fe02207ad4fabff552193c49766
Reviewed-on: https://chromium-review.googlesource.com/c/1268339
Commit-Queue: Sergio Villar <svillar@igalia.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#607556}
[modify] https://crrev.com/1bdcf632f3345eae5f589a5280fb85b4d4f210b1/chrome/browser/profiles/renderer_updater.cc
[modify] https://crrev.com/1bdcf632f3345eae5f589a5280fb85b4d4f210b1/chrome/browser/profiles/renderer_updater.h

Status: Fixed (was: Started)
Closing
Blocking: -894075

Sign in to add a comment