Fix CGaiaCredentialBase::GetAppNameAndCommandline() to use path to chrome once chrome handles the UI task for the credential provider.
Related to b/116019210
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/07e61f32529fdca97a8b120a00e9f622fede2374 commit 07e61f32529fdca97a8b120a00e9f622fede2374 Author: Tien Mai <tienmai@chromium.org> Date: Wed Nov 07 21:40:11 2018 Fix some missing permissions for the logon stub process needed to be able to run Chrome during winlogon Bug: 887444 Change-Id: Ie6c54855cee2b95ef6cb0de1829251d324548733 Reviewed-on: https://chromium-review.googlesource.com/c/1301850 Commit-Queue: Tien Mai <tienmai@chromium.org> Reviewed-by: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#606173} [modify] https://crrev.com/07e61f32529fdca97a8b120a00e9f622fede2374/chrome/credential_provider/gaiacp/os_process_manager.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b89c14029e4ecefce8fdab6d1fcb6f3711d4faab commit b89c14029e4ecefce8fdab6d1fcb6f3711d4faab Author: Tien Mai <tienmai@chromium.org> Date: Tue Nov 13 13:25:36 2018 Update inline_signin_ui to work in incognito mode - Added a new reason for the signin that requests only the login process to be executed and then takes the result from gaia and sends them through a new message added to the inline_login.js. This code path avoids all cals that try to perform operations on profiles - This new mode is used by GCPW to gather the necessary login information Bug: 887444 Change-Id: I84c62408b16c46a40360d7fc703b482d399cd76b Reviewed-on: https://chromium-review.googlesource.com/c/1286755 Commit-Queue: Tien Mai <tienmai@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Greg Thompson <grt@chromium.org> Reviewed-by: Mihai Sardarescu <msarda@chromium.org> Reviewed-by: Tommy Martino <tmartino@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Roger Tawa <rogerta@chromium.org> Reviewed-by: Jesse Doherty <jwd@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#607573} [modify] https://crrev.com/b89c14029e4ecefce8fdab6d1fcb6f3711d4faab/chrome/app/chromium_strings.grd [modify] https://crrev.com/b89c14029e4ecefce8fdab6d1fcb6f3711d4faab/chrome/browser/DEPS [modify] https://crrev.com/b89c14029e4ecefce8fdab6d1fcb6f3711d4faab/chrome/browser/resources/inline_login/inline_login.js [modify] https://crrev.com/b89c14029e4ecefce8fdab6d1fcb6f3711d4faab/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/b89c14029e4ecefce8fdab6d1fcb6f3711d4faab/chrome/browser/ui/browser_navigator.cc [add] https://crrev.com/b89c14029e4ecefce8fdab6d1fcb6f3711d4faab/chrome/browser/ui/startup/credential_provider_signin_dialog_win.cc [add] https://crrev.com/b89c14029e4ecefce8fdab6d1fcb6f3711d4faab/chrome/browser/ui/startup/credential_provider_signin_dialog_win.h [add] https://crrev.com/b89c14029e4ecefce8fdab6d1fcb6f3711d4faab/chrome/browser/ui/startup/credential_provider_signin_dialog_win_browsertest.cc [add] https://crrev.com/b89c14029e4ecefce8fdab6d1fcb6f3711d4faab/chrome/browser/ui/startup/credential_provider_signin_dialog_win_test_data.cc [add] https://crrev.com/b89c14029e4ecefce8fdab6d1fcb6f3711d4faab/chrome/browser/ui/startup/credential_provider_signin_dialog_win_test_data.h [add] https://crrev.com/b89c14029e4ecefce8fdab6d1fcb6f3711d4faab/chrome/browser/ui/startup/credential_provider_signin_info_fetcher_win.cc [add] https://crrev.com/b89c14029e4ecefce8fdab6d1fcb6f3711d4faab/chrome/browser/ui/startup/credential_provider_signin_info_fetcher_win.h [add] https://crrev.com/b89c14029e4ecefce8fdab6d1fcb6f3711d4faab/chrome/browser/ui/startup/credential_provider_signin_info_fetcher_win_unittest.cc [modify] https://crrev.com/b89c14029e4ecefce8fdab6d1fcb6f3711d4faab/chrome/browser/ui/startup/startup_browser_creator.cc [modify] https://crrev.com/b89c14029e4ecefce8fdab6d1fcb6f3711d4faab/chrome/browser/ui/startup/startup_browser_creator_impl.cc [modify] https://crrev.com/b89c14029e4ecefce8fdab6d1fcb6f3711d4faab/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc [modify] https://crrev.com/b89c14029e4ecefce8fdab6d1fcb6f3711d4faab/chrome/browser/ui/webui/signin/inline_login_handler_impl.h [add] https://crrev.com/b89c14029e4ecefce8fdab6d1fcb6f3711d4faab/chrome/credential_provider/common/BUILD.gn [rename] https://crrev.com/b89c14029e4ecefce8fdab6d1fcb6f3711d4faab/chrome/credential_provider/common/gcp_strings.cc [rename] https://crrev.com/b89c14029e4ecefce8fdab6d1fcb6f3711d4faab/chrome/credential_provider/common/gcp_strings.h [modify] https://crrev.com/b89c14029e4ecefce8fdab6d1fcb6f3711d4faab/chrome/credential_provider/gaiacp/BUILD.gn [modify] https://crrev.com/b89c14029e4ecefce8fdab6d1fcb6f3711d4faab/chrome/credential_provider/gaiacp/dllmain.cc [modify] https://crrev.com/b89c14029e4ecefce8fdab6d1fcb6f3711d4faab/chrome/credential_provider/gaiacp/gaia_credential_base.cc [modify] https://crrev.com/b89c14029e4ecefce8fdab6d1fcb6f3711d4faab/chrome/credential_provider/gaiacp/gaia_credential_base_unittests.cc [modify] https://crrev.com/b89c14029e4ecefce8fdab6d1fcb6f3711d4faab/chrome/credential_provider/gaiacp/gaia_credential_provider.cc [modify] https://crrev.com/b89c14029e4ecefce8fdab6d1fcb6f3711d4faab/chrome/credential_provider/gaiacp/gcp_utils.cc [modify] https://crrev.com/b89c14029e4ecefce8fdab6d1fcb6f3711d4faab/chrome/credential_provider/gaiacp/os_process_manager.cc [modify] https://crrev.com/b89c14029e4ecefce8fdab6d1fcb6f3711d4faab/chrome/credential_provider/gaiacp/reauth_credential.cc [modify] https://crrev.com/b89c14029e4ecefce8fdab6d1fcb6f3711d4faab/chrome/credential_provider/gaiacp/reg_utils.cc [modify] https://crrev.com/b89c14029e4ecefce8fdab6d1fcb6f3711d4faab/chrome/credential_provider/gaiacp/scoped_user_profile.cc [modify] https://crrev.com/b89c14029e4ecefce8fdab6d1fcb6f3711d4faab/chrome/credential_provider/test/gcp_setup_unittests.cc [modify] https://crrev.com/b89c14029e4ecefce8fdab6d1fcb6f3711d4faab/chrome/test/BUILD.gn [modify] https://crrev.com/b89c14029e4ecefce8fdab6d1fcb6f3711d4faab/components/keep_alive_registry/keep_alive_types.cc [modify] https://crrev.com/b89c14029e4ecefce8fdab6d1fcb6f3711d4faab/components/keep_alive_registry/keep_alive_types.h [modify] https://crrev.com/b89c14029e4ecefce8fdab6d1fcb6f3711d4faab/components/signin/core/browser/signin_metrics.cc [modify] https://crrev.com/b89c14029e4ecefce8fdab6d1fcb6f3711d4faab/components/signin/core/browser/signin_metrics.h [modify] https://crrev.com/b89c14029e4ecefce8fdab6d1fcb6f3711d4faab/components/signin/core/browser/signin_metrics_unittest.cc [modify] https://crrev.com/b89c14029e4ecefce8fdab6d1fcb6f3711d4faab/tools/metrics/actions/actions.xml [modify] https://crrev.com/b89c14029e4ecefce8fdab6d1fcb6f3711d4faab/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a43b2e633eacc1dcfab46d29e9ec405ed22860a5 commit a43b2e633eacc1dcfab46d29e9ec405ed22860a5 Author: Tien Mai <tienmai@chromium.org> Date: Tue Nov 20 15:13:51 2018 Redirect gpcw to run Chrome as the login stub Pass the hosted e-mail domain to the gaia sign in page through GCPW. Bug: 887444 Change-Id: Ie77034dadc3873de35bbf32a30d20364877ec328 Reviewed-on: https://chromium-review.googlesource.com/c/1333869 Reviewed-by: Greg Thompson <grt@chromium.org> Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Reviewed-by: Roger Tawa <rogerta@chromium.org> Reviewed-by: Tommy Martino <tmartino@chromium.org> Commit-Queue: Tien Mai <tienmai@chromium.org> Cr-Commit-Position: refs/heads/master@{#609708} [modify] https://crrev.com/a43b2e633eacc1dcfab46d29e9ec405ed22860a5/chrome/browser/resources/gaia_auth_host/authenticator.js [modify] https://crrev.com/a43b2e633eacc1dcfab46d29e9ec405ed22860a5/chrome/browser/ui/startup/OWNERS [modify] https://crrev.com/a43b2e633eacc1dcfab46d29e9ec405ed22860a5/chrome/browser/ui/startup/credential_provider_signin_dialog_win.cc [modify] https://crrev.com/a43b2e633eacc1dcfab46d29e9ec405ed22860a5/chrome/browser/ui/startup/credential_provider_signin_dialog_win_test_data.cc [modify] https://crrev.com/a43b2e633eacc1dcfab46d29e9ec405ed22860a5/chrome/browser/ui/startup/credential_provider_signin_dialog_win_test_data.h [modify] https://crrev.com/a43b2e633eacc1dcfab46d29e9ec405ed22860a5/chrome/browser/ui/startup/credential_provider_signin_info_fetcher_win_unittest.cc [modify] https://crrev.com/a43b2e633eacc1dcfab46d29e9ec405ed22860a5/chrome/browser/ui/webui/signin/inline_login_handler_impl.cc [modify] https://crrev.com/a43b2e633eacc1dcfab46d29e9ec405ed22860a5/chrome/credential_provider/DEPS [modify] https://crrev.com/a43b2e633eacc1dcfab46d29e9ec405ed22860a5/chrome/credential_provider/common/gcp_strings.cc [modify] https://crrev.com/a43b2e633eacc1dcfab46d29e9ec405ed22860a5/chrome/credential_provider/common/gcp_strings.h [modify] https://crrev.com/a43b2e633eacc1dcfab46d29e9ec405ed22860a5/chrome/credential_provider/gaiacp/BUILD.gn [modify] https://crrev.com/a43b2e633eacc1dcfab46d29e9ec405ed22860a5/chrome/credential_provider/gaiacp/gaia_credential_base.cc [modify] https://crrev.com/a43b2e633eacc1dcfab46d29e9ec405ed22860a5/chrome/credential_provider/gaiacp/gaia_credential_base.h [modify] https://crrev.com/a43b2e633eacc1dcfab46d29e9ec405ed22860a5/chrome/credential_provider/gaiacp/gaia_credential_provider.cc [modify] https://crrev.com/a43b2e633eacc1dcfab46d29e9ec405ed22860a5/chrome/credential_provider/gaiacp/gcp_utils.cc [modify] https://crrev.com/a43b2e633eacc1dcfab46d29e9ec405ed22860a5/chrome/credential_provider/gaiacp/gcp_utils.h [modify] https://crrev.com/a43b2e633eacc1dcfab46d29e9ec405ed22860a5/chrome/credential_provider/gaiacp/gcp_utils_unittests.cc [modify] https://crrev.com/a43b2e633eacc1dcfab46d29e9ec405ed22860a5/chrome/credential_provider/test/BUILD.gn [add] https://crrev.com/a43b2e633eacc1dcfab46d29e9ec405ed22860a5/chrome/credential_provider/test/gcp_gls_output_unittest.cc
Comment 1 by rogerta@chromium.org
, Oct 5