New issue
Advanced search Search tips

Issue 887434 link

Starred by 1 user
Status: Fixed
Owner:
svil...@igalia.com
Closed: Oct 19
Cc:
ma...@igalia.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 887439
Blocking:
issue 887433
issue 887445
issue 887457



Sign in to add a comment

Provide API to replace SigningManagerBase::Observer::GoogleSigninFailed

Project Member Reported by sdefresne@chromium.org, Sep 20 
Required to convert the following classes to implement IdentityManager::Observer instead:
- SigninManagerAndroid
- SyncEngine
- AboutSigninInternals
- SigninTracker

This is also used by those test classes:
- TestSigninManagerObserver

Comment 1 by sdefresne@chromium.org, Sep 20

Blockedon: 887439

Comment 2 by sdefresne@chromium.org, Sep 20

Blocking: 887445

Comment 3 by sdefresne@chromium.org, Sep 20

Blocking: 887457

Comment 4 by ma...@igalia.com, Oct 17 

@sdefresne Any idea of when this API might be available? I was working on parts of SyncEngine as part of  crbug.com/809440  and this one is I believe the only reason why SyncEngine can't be migrated away of SiginManager yet ( crbug.com/887457 ).

Comment 5 by ma...@igalia.com, Oct 17

Cc: ma...@igalia.com

Comment 6 by sdefresne@chromium.org, Oct 18 

I'll see whether I can get the missing API by end of week.

Comment 7 by ma...@igalia.com, Oct 18 

Great! Thanks for the heads-up!

Comment 8 by sdefresne@chromium.org, Oct 19

Owner: svil...@igalia.com
Status: Fixed (was: Assigned)
This has already been implemented by svillar@ in https://chromium-review.googlesource.com/c/1257835
►

Sign in to add a comment