need clang tot and android bot and opt-in try bot that builds with thinlto |
|||||
Issue descriptionThe last clang roll broke the android official build ( issue 887272 ) due to some lto issue. We didn't see that on the tot waterfall since there's no tot bot for that config. We should also have an opt-in trybot for that config. pcc, does anyone own thinlto-for-android? Is that just you, or are there folks on the ops side who could help with setting this up?
,
Sep 24
[Bug triage] Is this bug about adding new builders somewhere in https://ci.chromium.org/p/chromium?
,
Sep 24
,
Sep 25
Should this be roughly the same as ToTAndroid w/ use_thin_lto=true? Are there other things in the build or test configuration that should differ from ToTAndroid?
,
Sep 25
Ideally the same bot config as the bot failing in issue 887272 was using.
,
Sep 28
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/81a1162a217b152a87bc962a87dd3ffa63792433 commit 81a1162a217b152a87bc962a87dd3ffa63792433 Author: John Budorick <jbudorick@google.com> Date: Fri Sep 28 23:29:17 2018
,
Sep 28
The following revision refers to this bug: https://chrome-internal.googlesource.com/infradata/config/+/216ff455080a4f94ea455f4ef2ee62b8417f1092 commit 216ff455080a4f94ea455f4ef2ee62b8417f1092 Author: John Budorick <jbudorick@google.com> Date: Fri Sep 28 23:44:38 2018
,
Sep 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/38f3747f1ade49b5f3d897eea1a8a9b73e77bc38 commit 38f3747f1ade49b5f3d897eea1a8a9b73e77bc38 Author: John Budorick <jbudorick@chromium.org> Date: Sat Sep 29 00:30:36 2018 chromium_tests: add recipe config for chromium.clang:ToTAndroidLTO. Bug: 887429 Change-Id: Ibf7ee03f9c0e538896dfd65d5e5b12dc05e60ac1 Reviewed-on: https://chromium-review.googlesource.com/1252822 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by: Ben Pastene <bpastene@chromium.org> [modify] https://crrev.com/38f3747f1ade49b5f3d897eea1a8a9b73e77bc38/scripts/slave/recipe_modules/chromium_tests/chromium_clang.py
,
Sep 29
,
Sep 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/11cc0bafaf9dcb896ad3a42ccc8392299cfb8410 commit 11cc0bafaf9dcb896ad3a42ccc8392299cfb8410 Author: John Budorick <jbudorick@chromium.org> Date: Sat Sep 29 01:39:05 2018 Add compile and luci configs for chromium.clang:ToTAndroidOfficial. Bug: 887429 Change-Id: I5605019fb5373c6df8127b8dd689ab64f57fd25c Reviewed-on: https://chromium-review.googlesource.com/1253062 Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#595285} [modify] https://crrev.com/11cc0bafaf9dcb896ad3a42ccc8392299cfb8410/infra/config/global/cr-buildbucket.cfg [modify] https://crrev.com/11cc0bafaf9dcb896ad3a42ccc8392299cfb8410/infra/config/global/luci-milo.cfg [modify] https://crrev.com/11cc0bafaf9dcb896ad3a42ccc8392299cfb8410/infra/config/global/luci-scheduler.cfg [modify] https://crrev.com/11cc0bafaf9dcb896ad3a42ccc8392299cfb8410/testing/buildbot/chromium.clang.json [modify] https://crrev.com/11cc0bafaf9dcb896ad3a42ccc8392299cfb8410/testing/buildbot/waterfalls.pyl [modify] https://crrev.com/11cc0bafaf9dcb896ad3a42ccc8392299cfb8410/tools/mb/mb_config.pyl
,
Sep 29
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d31a2d77913a6096326eef456d6bfbc2e5f27226 commit d31a2d77913a6096326eef456d6bfbc2e5f27226 Author: John Budorick <jbudorick@chromium.org> Date: Sat Sep 29 04:48:08 2018 ToTAndroidOfficial: Switch official to official_optimize. is_chrome_branded requires an internal checkout. TBR=bpastene@chromium.org Bug: 887429 Change-Id: Ia98b948ef94e81738d695dfe2e1e0d2b5868c600 Reviewed-on: https://chromium-review.googlesource.com/1252465 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#595299} [modify] https://crrev.com/d31a2d77913a6096326eef456d6bfbc2e5f27226/tools/mb/mb_config.pyl
,
Oct 2
The bot now exists: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ToTAndroidOfficial ! It's failing sizes a lot: /b/s/w/ir/cache/vpython/829f91/bin/python /b/s/w/ir/cache/builder/src/infra/scripts/legacy/scripts/slave/chromium/sizes.py --target Release --platform android nm: /b/s/w/ir/cache/builder/src/out/Release/libchrome.so: no symbols # Static initializers in /b/s/w/ir/cache/builder/src/out/Release/libchrome.so: # HINT: To get this list, run tools/linux/dump-static-initializers.py # HINT: diff against the log from the last run to see what changed # Found 0 static initializers in 0 files. RESULT libchrome.so: libchrome.so= 49680100 bytes RESULT libchrome.so-stripped: stripped= 49680100 bytes RESULT libchrome.so-text: text= 47460212 bytes RESULT libchrome.so-data: data= 2212321 bytes RESULT libchrome.so-bss: bss= 1406612 bytes RESULT libchrome.so-si: initializers= 4 files RESULT libchrome.so-textrel: textrel= 0 relocs <Thread(Thread-1, started 140126456915712)> ProcessRead: proc.stdout finished. <Thread(Thread-1, started 140126456915712)> ProcessRead: cleaning up. <Thread(Thread-2, started daemon 140126448523008)> TimedFlush: Finished <Thread(Thread-1, started 140126456915712)> ProcessRead: finished. exit code (as seen by runtest.py): 0 Sending result 1 of 7 to dashboard. Error while uploading chartjson data: Traceback (most recent call last): File "/b/s/w/ir/kitchen-checkout/build/scripts/slave/results_dashboard.py", line 493, in _SendResultsJson urllib2.urlopen(req) File "/b/s/w/ir/cipd_bin_packages/lib/python2.7/urllib2.py", line 154, in urlopen return opener.open(url, data, timeout) File "/b/s/w/ir/cipd_bin_packages/lib/python2.7/urllib2.py", line 435, in open response = meth(req, response) File "/b/s/w/ir/cipd_bin_packages/lib/python2.7/urllib2.py", line 548, in http_response 'http', request, response, code, msg, hdrs) File "/b/s/w/ir/cipd_bin_packages/lib/python2.7/urllib2.py", line 473, in error return self._call_chain(*args) File "/b/s/w/ir/cipd_bin_packages/lib/python2.7/urllib2.py", line 407, in _call_chain result = func(*args) File "/b/s/w/ir/cipd_bin_packages/lib/python2.7/urllib2.py", line 556, in http_error_default raise HTTPError(req.get_full_url(), code, msg, hdrs, fp) HTTPError: HTTP Error 403: Forbidden agrieve: The bot does official builds, but with trunk clang to make sure that works. Should we just add a toggle to sizes to disable uploading on this bot?
,
Oct 2
thakis: you still want a manual trybot for this, correct? AFAICT it'll be the first clang tot trybot.
,
Oct 2
Oh, the trybot shouldn't use tot clang. We want a tot bot (which we now have, thanks!), and then a try bot for the regular official android bot, so that we can request that on clang rolls to check that the new pinned clang works.
,
Oct 2
ah, gotcha.
,
Oct 2
The now-on-by-default android-binary-size trybot builds official, but doesn't actually run chrome at all. re:sizes - yes, I think disabling uploading makes sense if you have no need to upload them.
,
Oct 2
> The now-on-by-default android-binary-size trybot builds official, but doesn't actually run chrome at all. Hm, so far we've only seen issues while building, not running. So that might be enough for now. > I think disabling uploading makes sense if you have no need to upload them. Do you happen to know what calls sizes.py? I went hunting through the recipes but couldn't find it.
,
Oct 4
> Do you happen to know what calls sizes.py? I went hunting through the recipes but couldn't find it. The size data seems useful though. I've filed crbug.com/892065 for whitelisting the IPs of the builders
,
Oct 4
#19: the IP for this machine is unlikely to be static.
,
Oct 4
> #19: the IP for this machine is unlikely to be static. I've updated the whitelisting bug. I don't know how the perf dashboard deals with that. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by thakis@chromium.org
, Sep 20