New issue
Advanced search Search tips

Issue 887424 link

Starred by 9 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

can't select bookmarks at the bottom of list

Reported by lilma...@earthlink.net, Sep 20

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3557.0 Safari/537.36

Steps to reproduce the problem:
1. open tab page
2.in other bookmarks, when I scroll down beyond what is normally visible, if I click a selection, the list closes 
3.While scrolling down beyond a certain point, the hilight stops showing. 

What is the expected behavior?
I should be able to scroll down the list and be able to select a bookmark

What went wrong?
In  my Chrome Canary ver.71.0... if I open my bookmarks and scroll down in some of my longer columns, I can not select the desired site.  If I try to select an entry the column just disappears.  In bookmark manager I am able to access the pages, even if they are far down the list.  

When opening a new tab page, I can't access a site if it is too far down in the column in my 'other bookmarks', It has worked before, no problems, this is a recent occurrence.   I have tried deleting Canary, and all its files in my app folders, reinstalling, didn't help.  I tried undoing synch between my normal Chrome and Canary, rebooting the computer, that didn't work.  In my normal ver. of Chrome ver. 69.0.3497.100 everything works as it should, just not im my version of Canary.

Did this work before? Yes not entirely sure, seems to be recent

Chrome version: 71.0.3557.0  Channel: canary
OS Version: 10.0
Flash Version:
 
Labels: Needs-Bisect Needs-Triage-M71
Components: -UI UI>Browser>Bookmarks
Cc: vamshi.kommuri@chromium.org
Labels: Triaged-ET Needs-Feedback
Thanks for filing the issue!

Unable to reproduce the issue on reported chrome version 71.0.3557.0 using Windows 10 with the below mentioned steps.
1. Launched Chrome
2. Bookmarked many webpages
3. Opened Chrome://bookmarks
4. Scrolled down to the bottom of the bookmarks
Able to scroll and select the bookmarks at the very bottom of the page. Attaching the screencast of the same.

@Reporter: Could you please have a look at the screencast and let us know if we have missed anything in the process. Any further inputs from your end may be helpful.
887424.mp4
3.7 MB View Download
Thanks for the reply.  I am a long time Chrome user and over the years, and being kind of a pack rat, some of the columns are quite a bit longer than you example.  It happens when I scroll past the 42nd entry.  I've included two photos of the occurrence.  I circled the cursor, you can see in the pics where the cursor in one is hi-lighted and the other is not.  
IMG_4359-1.jpg
477 KB View Download
IMG_4360-1.jpg
469 KB View Download
Project Member

Comment 5 by sheriffbot@chromium.org, Sep 21

Labels: -Needs-Feedback
Thank you for providing more feedback. Adding the requester to the cc list.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
I am having exact same issue, was not able to select loads of boobookmarks, specially those at the bottom area,
I ended up cleaning up the bookmark manager and actually deleted lots of bookmarks that I thought I was not using much. Please fix this ASAP
My Chrome Canary version is: Version 71.0.3558.0 (Official Build) canary (64-bit)
I have the same issue.

For the reviewer, please note.
This bug only in the new context menu UI, chrome changed the context menu UI a little bit.

To reproduce the bug.
You have to create a lot of bookmarks or try to import attached bookmarks file.
Bookmarks_Demo.html
3.9 KB View Download
2018-09-21 23-24-36-936.mp4
531 KB View Download
same issue clean build win 10 / 

Version 71.0.3558.0 (Official Build) canary (32-bit)

in the settings menu / the menu has a blank section / and as shown in the video by comment 8, bookmark issue
canary bug.png
886 KB View Download
Labels: -Pri-2 -Needs-Bisect hasbisect-per-revision RegressedIn-71 Target-71 ReleaseBlock-Dev M-71 FoundIn-71 OS-Linux OS-Mac Pri-1
Owner: kylixrd@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on reported chrome version 71.0.3557.0 and on the latest canary 71.0.3559.0 using Windows 10, Ubuntu 14.04 and Mac 10.13.1

Bisect Information:
-------------------
Good Build: 71.0.3555.0
Bad Build:  71.0.3556.0

You are probably looking for a change made after 592155 (known good), but no later than 592156 (first known bad).
CHANGELOG URL:
 https://chromium.googlesource.com/chromium/src/+log/e2181f8270226027f905c30fd7f6d62af03eb3e8..1922e955fae5e266603059a97356ff8af058f049
Suspecting: https://chromium.googlesource.com/chromium/src/+/1922e955fae5e266603059a97356ff8af058f049

@Allen Bauer: Please help in assigning it to the right owner, if this is not related to your change. Adding RB-Dev as this seems to be a recent regression.

Thanks!
Cc: gov...@chromium.org blundell@chromium.org ligim...@chromium.org ajha@chromium.org
Looks like revert of the suspected CL is already sent to CQ here: https://chromium-review.googlesource.com/c/chromium/src/+/1238568.

blundell@/kylixrd@: Once the CL is reverted, could you please merge the same to canary branch 3559 as well to create a Dev RC for tomorrow.
Cc: thomasanderson@chromium.org
The revert didn't apply cleanly due to a conflict with https://chromium-review.googlesource.com/c/chromium/src/+/1237519. Allen and/or Thomas, can you look at resolving those conflicts and pushing through the revert? I'm not at all familiar with this code, and I don't want to make an inadvertent error in conflict resolution.
 Issue 888404  has been merged into this issue.
Tom, can I have an update on this issue?We are blocked from Dev release due to this bug.
Cc: pkasting@chromium.org
It should be safe to revert [1] and then [2], then merge both reverts to 3559.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1237519
[2] https://chromium-review.googlesource.com/c/chromium/src/+/1229173
Thank you ligimole@ and  thomasanderson@.

thomasanderson@, pls revert CLs listed at #15 and merge to 3559 branch.

Cc: kylixrd@chromium.org
Owner: thomasanderson@chromium.org
Status: Started (was: Assigned)
Reverts created:
https://chromium-review.googlesource.com/c/chromium/src/+/1240713
https://chromium-review.googlesource.com/c/chromium/src/+/1240733

The CQ is running for both, so it will take some time for them to land.
Is it safe to skip CQ and merge to 3559?
> Is it safe to skip CQ and merge to 3559?

I'd prefer not to since the CLs landed more than a couple days ago.

As discussed offline, the CQ will take about an hour (fortunately, the CQ is able to run on both CLs concurrently).  If any individual bot flakes and needs to rerun, I'll skip the CQ.
Ok, sounds good. 
Project Member

Comment 21 by bugdroid1@chromium.org, Sep 24

Labels: merge-merged-3559
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc041f1eaef387a886767e99b1c0e4f94f5dc50b

commit fc041f1eaef387a886767e99b1c0e4f94f5dc50b
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Mon Sep 24 20:04:25 2018

[Merge to 3559] Revert "[GTK] Fix menu background color regression"

> This reverts commit c551571fa598ce656b209364cc4e407f354067c8.
>
> Reason for revert: Need to revert a dependent CL (https://chromium-review.googlesource.com/c/chromium/src/+/1229173), so reverting this to prevent merge conflicts
>
> Original change's description:
> > [GTK] Fix menu background color regression
> >
> > Regressed after 9c5131ad426872a1c931a6e3a27bbd4c469b7721.  This caused the menu
> > background to always render white even though the text colors would still be
> > styled using the system theme.  This caused illegible text when the menu
> > background was supposed to be dark.
> >
> > R=​pkasting
> > TBR=sky
> >
> > Change-Id: I39b836e0941cbfc033515fe3891ecd42d89d73a4
> > Reviewed-on: https://chromium-review.googlesource.com/1237519
> > Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> > Reviewed-by: Peter Kasting <pkasting@chromium.org>
> > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#593039}
>
> TBR=sky@chromium.org,pkasting@chromium.org,thomasanderson@chromium.org
> NOTRY=true
> NOPRESUBMIT=true
>
> Change-Id: If1fa983c97f0942cea3fccad14372ed1f5922080
> Reviewed-on: https://chromium-review.googlesource.com/1240713
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#593649}
> Bug:

TBR=sky@chromium.org,pkasting@chromium.org,thomasanderson@chromium.org
BUG= 887424 
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Change-Id: If24e4ba99e096786e4fc84c793fd3d6d0b31683a
Reviewed-on: https://chromium-review.googlesource.com/1241233
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/branch-heads/3559@{#8}
Cr-Branched-From: b522cfef32adcfdedf00a6e03362101db42bd80a-refs/heads/master@{#593399}
[modify] https://crrev.com/fc041f1eaef387a886767e99b1c0e4f94f5dc50b/ui/views/controls/menu/menu_scroll_view_container.cc
[modify] https://crrev.com/fc041f1eaef387a886767e99b1c0e4f94f5dc50b/ui/views/controls/menu/menu_scroll_view_container.h

Project Member

Comment 22 by bugdroid1@chromium.org, Sep 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc2d59606974db2ab66d96b206a56b0bc5e1f362

commit cc2d59606974db2ab66d96b206a56b0bc5e1f362
Author: Tom Anderson <thomasanderson@chromium.org>
Date: Mon Sep 24 20:07:17 2018

[Merge to 3559] Revert "Reland "Under refresh, use the same menu options for Windows/Linux as under Mac""

> This reverts commit 1922e955fae5e266603059a97356ff8af058f049.
>
> Reason for revert: Causing  bug 887424 
>
> Original change's description:
> > Reland "Under refresh, use the same menu options for Windows/Linux as under Mac"
> >
> > This is a reland of 9c5131ad426872a1c931a6e3a27bbd4c469b7721
> >
> > Cannot reproduce the flake. Relanding for more information.
> >
> > Original change's description:
> > > Under refresh, use the same menu options for Windows/Linux as under Mac
> > >
> > > Use the BubbleBorder for the menus since the drop-shadow under Windows
> > > doesn't track the shape of the menu. We also have much more control over
> > > the shape and depth of the drop-shadow.
> > >
> > > Bug: 837782
> > > Change-Id: I91b9340251c2cd0b60e3b3f66d450a4791113007
> > > Reviewed-on: https://chromium-review.googlesource.com/1159532
> > > Commit-Queue: Allen Bauer <kylixrd@chromium.org>
> > > Reviewed-by: Evan Stade <estade@chromium.org>
> > > Reviewed-by: Michael Wasserman <msw@chromium.org>
> > > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#590731}
> >
> > TBR=ellyjones@chromium.org
> > TBR=msw@chromium.org
> > TBR=estade@chromium.org
> >
> > Bug: 837782
> > Change-Id: I80a07fb2d716c9372d18a8d48df3e7e00ff286ab
> > Reviewed-on: https://chromium-review.googlesource.com/1229173
> > Commit-Queue: Allen Bauer <kylixrd@chromium.org>
> > Reviewed-by: Allen Bauer <kylixrd@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#592156}
>
> TBR=ellyjones@chromium.org,msw@chromium.org,estade@chromium.org,kylixrd@chromium.org
> NOTRY=true
> NOPRESUBMIT=true
>
> Bug: 837782
> Change-Id: Ie834df815bd1fb1d0f49d7ddc84adecf75ea351e
> Reviewed-on: https://chromium-review.googlesource.com/1240733
> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
> Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#593651}

TBR=ellyjones@chromium.org,msw@chromium.org,estade@chromium.org,kylixrd@chromium.org
BUG= 887424 
NOTRY=true
NOPRESUBMIT=true
NOTREECHECKS=true

Change-Id: If61535acd638674e6ae4d3e0f7d6850be9e6f8cc
Reviewed-on: https://chromium-review.googlesource.com/1241234
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/branch-heads/3559@{#9}
Cr-Branched-From: b522cfef32adcfdedf00a6e03362101db42bd80a-refs/heads/master@{#593399}
[modify] https://crrev.com/cc2d59606974db2ab66d96b206a56b0bc5e1f362/chrome/browser/ui/window_sizer/window_sizer_ash_uitest.cc
[modify] https://crrev.com/cc2d59606974db2ab66d96b206a56b0bc5e1f362/ui/views/controls/menu/menu_config.cc
[modify] https://crrev.com/cc2d59606974db2ab66d96b206a56b0bc5e1f362/ui/views/controls/menu/menu_config.h
[modify] https://crrev.com/cc2d59606974db2ab66d96b206a56b0bc5e1f362/ui/views/controls/menu/menu_config_chromeos.cc
[modify] https://crrev.com/cc2d59606974db2ab66d96b206a56b0bc5e1f362/ui/views/controls/menu/menu_config_linux.cc
[modify] https://crrev.com/cc2d59606974db2ab66d96b206a56b0bc5e1f362/ui/views/controls/menu/menu_config_mac.mm
[modify] https://crrev.com/cc2d59606974db2ab66d96b206a56b0bc5e1f362/ui/views/controls/menu/menu_config_win.cc
[modify] https://crrev.com/cc2d59606974db2ab66d96b206a56b0bc5e1f362/ui/views/controls/menu/menu_controller.cc
[modify] https://crrev.com/cc2d59606974db2ab66d96b206a56b0bc5e1f362/ui/views/controls/menu/menu_controller_unittest.cc
[modify] https://crrev.com/cc2d59606974db2ab66d96b206a56b0bc5e1f362/ui/views/controls/menu/menu_item_view_unittest.cc
[modify] https://crrev.com/cc2d59606974db2ab66d96b206a56b0bc5e1f362/ui/views/controls/menu/menu_scroll_view_container.cc
[modify] https://crrev.com/cc2d59606974db2ab66d96b206a56b0bc5e1f362/ui/views/controls/menu/menu_scroll_view_container.h

Status: Fixed (was: Started)
Thank you for the reverts merge to dev branch 3559. Triggering dev RC now from 3559 branch.
Dev RC #71.0.3559.6 in progress.
Labels: TE-Verified-71.0.3559.6 TE-Verified-M71
Verified the fix on Mac 10.13.1, Windows-10 and Ubuntu 14.04 using Chrome version #71.0.3559.6 as per the test file in comment #8.
Attaching screen cast for reference.
Observed the bookmarks in the list are selectable.
Hence, the fix is working as expected. 
Adding the verified labels.
Note: Able to reproduce the issue on chrome version with out fix.

Thanks...!!



887424.mp4
1016 KB View Download
Today's update ver. 71.0.33561.0 seems to have fixed the problem on my W 10 computer.  Thanks for the fix.

Sign in to add a comment