Vertical multi-column is broken.
Reported by
babata...@gmail.com,
Sep 20
|
|||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3557.0 Safari/537.36 Steps to reproduce the problem: 1. Open attached test.html 2. Make the browser window smaller. What is the expected behavior? The text is laid out in two columns (by "column-count: 2"). What went wrong? The text overflows. Did this work before? Yes 69.0.3497.100 Does this work in other browsers? Yes Chrome version: 71.0.3557.0 Channel: canary OS Version: 10.0 Flash Version:
,
Sep 21
Thanks for filing the issue! Able to reproduce the issue on reported chrome version 71.0.3557.0 using Windows 10, Ubuntu 14.04 and Mac 10.13.1 Bisect Information: ------------------- Good Build: 71.0.3544.0 Bad Build: 71.0.3545.0 You are probably looking for a change made after 589274 (known good), but no later than 589275 (first known bad). CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/fe7bd3083d2ff4ba834bfca33eee1cfc209d7d68..7b0c04464aec2a3dc0f059d619e8f3552fc035bb Suspecting: https://chromium.googlesource.com/chromium/src/+/7b0c04464aec2a3dc0f059d619e8f3552fc035bb Review URL: https://chromium-review.googlesource.com/1181644 @Xianzhu Wang: Please help in assigning it to the right owner if this is not related to your change. Adding RB-Stable as this seems to be a recent regression, please remove if not required.
,
Sep 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5a5647c52f752cbd219ab7d81b6324910e196a65 commit 5a5647c52f752cbd219ab7d81b6324910e196a65 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Mon Sep 24 16:55:30 2018 [PE] Fix fragment clip and paint offset under multicol vertical-rl scrolled The previous code in VisualOffsetFromPaintOffsetRoot() converting the result into scrolling contents space used ScrolledContentOffset which mismatched the new ScrollTranslation which also includes scroll origin. Now use ScrollTranslation instead. Also removed the wrong remedy about scroll origin in one of the callers. Bug: 887423 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9a72ed6ddc066c5b4c9970037ed4c4287c5a2f0f Reviewed-on: https://chromium-review.googlesource.com/1239170 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#593572} [modify] https://crrev.com/5a5647c52f752cbd219ab7d81b6324910e196a65/third_party/WebKit/LayoutTests/TestExpectations [add] https://crrev.com/5a5647c52f752cbd219ab7d81b6324910e196a65/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-under-vertical-rl-scroll-ref.html [add] https://crrev.com/5a5647c52f752cbd219ab7d81b6324910e196a65/third_party/WebKit/LayoutTests/external/wpt/css/css-multicol/multicol-under-vertical-rl-scroll.html [modify] https://crrev.com/5a5647c52f752cbd219ab7d81b6324910e196a65/third_party/blink/renderer/core/paint/paint_property_tree_builder.cc [modify] https://crrev.com/5a5647c52f752cbd219ab7d81b6324910e196a65/third_party/blink/renderer/core/paint/paint_property_tree_builder_test.cc
,
Sep 24
,
Sep 25
I've confirmed that the issue is fixed on 71.0.3561.0. Thanks! |
|||
►
Sign in to add a comment |
|||
Comment 1 by susan.boorgula@chromium.org
, Sep 20